Skip to content

Commit

Permalink
Remove superfluous logic in revolver/rack() (#3127)
Browse files Browse the repository at this point in the history
## About The Pull Request
I was reviewing `revolver.dm` and noticed a bit of duplicated logic.

While "twice to be sure" is usually a good idea for using a gun, it's
probably not necessary here.

## Why It's Good For The Game
Clean code is good code?

## Changelog
:cl:
fix: Cleaned up some logic in revolver safety
/:cl:
  • Loading branch information
blinkdog authored Jun 21, 2024
1 parent 8e2cde7 commit c8d3828
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion code/modules/projectiles/guns/ballistic/revolver.dm
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@
to_chat(user, "<span class='notice'>You rack the [bolt_wording] of \the [src].</span>")
playsound(src, rack_sound, rack_sound_volume, rack_sound_vary)

if((!safety && !semi_auto) || (!safety && !semi_auto))
if(!safety && !semi_auto)
chamber_round(TRUE)
SEND_SIGNAL(src, COMSIG_UPDATE_AMMO_HUD)
update_appearance()
Expand Down

0 comments on commit c8d3828

Please sign in to comment.