Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTSV Tegus-class Logistics Freighter #1880

Closed
wants to merge 62 commits into from

Conversation

goober3
Copy link
Member

@goober3 goober3 commented Apr 9, 2023

About The Pull Request

image

1

2

5

6

ough
Adds a Nanotrasen Logistics Freighter with a large shuttle for performing mining & engineering operations.

A full telecomms setup, a relay linking the shuttle with the mothership, and a spyglass kit facilities Field Technician to Mothership communication, allowing expedition teams to travel long distances whilst still remaining connected to the Tegus.

This PR also ports Fikou's spyglass rework from here (this was included in the original Columba PR, which is closed now!)
and the Tegu from here
description of the Tegu from Valorium

Why It's Good For The Game

Columba But Better
shiptest's most unatomized ship PR 2023

Changelog

🆑
add: The Tegus-class Logistics Freighter, a Nanotrasen mining / engineering ship with a large subshuttle.
add: The Tegu, sprite by Aspev
tweak: Spyglasses use actions now
add: The Micro SMES, for use on subshuttles
add: The Telecomms Parts design disk, prints telecomms parts from an autolathe.
/:cl:

@goober3 goober3 requested a review from a team as a code owner April 9, 2023 01:52
@github-actions github-actions bot added Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. labels Apr 9, 2023
@goober3 goober3 requested a review from a team as a code owner April 9, 2023 17:07
@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. labels Apr 9, 2023
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fucking love tegus you jsut dont understand

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Apr 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Apr 9, 2023
Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

unconnected vent and scrupper

image

no need for the manifold to go into the wall

image

please replace it with "tegus_shield_port"!

the ship looks rad. Good work!

@goober3
Copy link
Member Author

goober3 commented Apr 13, 2023

the checks have somehow fixed themselves. Good.

@goober3
Copy link
Member Author

goober3 commented Apr 14, 2023

the checks have somehow unfixed themselves. Bad.

//your subshuttle here
/datum/map_template/shuttle/subshuttles/nanotrasen_tegus
file_name = "nanotrasen_shuttle_tegus"
name = "Tegus Transport Shuttle"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give it a different name than the ship

Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The shutters on the subshuttle need to start closed. You get weird space wind and trouble with freespawning it otherwise.
I'd also like it one of the holofields was replaced with a cycling airlock.
StrongDMM_h1SqbcNbbB
lockers go on 28/-28
StrongDMM_q3PToBHOOH
There needs to be a cable under the terminal for it to work
image
Use /three_quarters to reduce file size.
StrongDMM_XKF1HRWOJq
Give this room more of a tech bend. Try having some techfloor under the machines. To my eye it blends together with the rest of the ship far too much
StrongDMM_m7M2YXw4aq
Ditto down here
image
Where is THEIR BED
Also lockers
image
Don't mix catwalks and pumps. It looks like shit.
StrongDMM_LQ3tRvCGkF
Set the density on the booze-o to 0 and pixelshift it onto a wall.
StrongDMM_ywAI8RXSNy
Firelocks on stairs can ruin the vertical effect. Consider moving it back
StrongDMM_Qw3nDCki29
Run the supply pipe with the scrubber pipe so you don't have atmos machine - pipe overlap
image
Either or. If you want them to have the choice give them the boards and make it so they have to construct them.
StrongDMM_k8bs1svMGD
MAKE IT SYMMETRICAL
StrongDMM_GK3iNgy5Y7
I'd have airlocks leading into this room. Also ditch the stairs and the catwalks. Make it seem more like an office - ready room.

Right now the entire ship feels very flat I think this is because you only used 3-4 types of tiles, some stairs, and decalling. Flat isn't bad, but it can make things less interesting. I'd experiment with stronger decal colors, different tile types, and establishing theming to areas, because some of the placement feels flat out random to me. The mining room and bar are probably the most stand out offenders to this.
StrongDMM_P9ZuzjL3SB
Also consider using some interior reinforced hull tiles here.

image
Honestly the nose could be expanded to give it some proper cargo areas. It really feels like a shape first design second ship, leading to things like the semi-random filing cabinets, or the mining room.
StrongDMM_ce88xk58lV
Airlocks this size should have 2 vents for quick cycling.

Consider making a subtype of Ions that are less efficient to encourage usage of the subshuttle. You can't really force it but it should be the preferable alternative.

@goober3
Copy link
Member Author

goober3 commented Apr 22, 2023

review jumpscare

Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a docking point for subshuttles on the outside.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Apr 26, 2023
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Aug 18, 2023
@Erikafox Erikafox dismissed Latentish’s stale review August 18, 2023 02:45

this review sucks

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 15, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 16, 2023
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 15, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 15, 2023
Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Poster light

also add lightswitches

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 21, 2023
@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. and removed Merge Conflict Use Git Hooks, you're welcome. labels Nov 13, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 14, 2023
maybe fixes tests

Signed-off-by: tmtmtl30 <[email protected]>
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 12, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jan 1, 2024
@Zevotech
Copy link
Contributor

Zevotech commented Jan 4, 2024

Please for the love of god add lightswitches to the ship and subshuttle

Replace these with the new good rations
image

Give the other plasma pacman 5 sheets as well, or maybe replace it with some other kind of pacman for diversity. A bad roll on the solars might cause power issues. Also see if you can put the fuel in a crate or something. Having it sat on top of the generator looks weird.
image

Gngineering in general looks kind of empty, maybe add a locker or a desk for whoever works back here, a power monitoring console would also be appreciated. Also, replace the air canister with a high pressure airtank. You'll get maybe five uses out of the airlocks before the canister runs out and they stop working. The airlocks also straight up dont work until the canister is wrenched down.
image

Give the empty crates some junk or spare mining gear maybe. Add more trash around, maybe a crate shelf, make it FEEL like a cargo bay. Also, probably move that pipe dispenser to engineering. Not sure why its just sitting there.
image

Did you copy this disk from the vela/cepheus? see if you can get rid of those CMM designs on there.
image

Feels like there could be more in here. Maybe toss in a few cleaner grenades, a maid outfit or some maintenance loot.
image

Maybe make the mining camera a small item so it fits into pockets. Also the captains locker has independent captains gloves in it. I like the emergency signaler, nice touch. You can change the ships starting funds in the JSON, maybe give it a bit more than 2000 considering its dedicated to logistics?
image

Throw a crate at the end for the refined materials to be put into. Otherwise, very nice smelting setup! Functions well.
image

This computer doesn't seem to work. Also, why is it here? I'd replace it with something else.
image

I'd recommend throwing on some exterior defenses similar to the ones on the Vela to block potential debris or meteors. Good way to use this empty space.
image

  1. The subshuttle starts with no fuel. 2. The prechargers are from the fucking PILL CLASS. they have 0 DENSITY. Please use normal prechargers. 3. The airlock on the subshuttle does not work. Might be related to how the layer adapters are placed, look at other ships airlocks to see how they do it. 4. Either add access buttons to the outside of the subshuttle or move them to where they can be pressed from both inside and outside. 5. Give the pilot a proximity crew pinpointer instead of a normal one.
    image
    image

@goober3
Copy link
Member Author

goober3 commented Jan 4, 2024

yeah. i think i'm going to shelve this for a remap in the future. this ship could be much, much better.

@goober3 goober3 closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Stale Exempt Take your time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants