Ports displacement filters for height/dwarfism #1916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Height filters
github-actions
bot
added
Code change
Replaces body_size with height filters, integrating them into preferences
Move the height selector to where it once stood, and remove a few empty commas I forgot even though they don't really do anything
thgvr
changed the title
|
Should probably have a more descriptive changelog if I'll be honest, clarify that dna body_size was replaced with the height filters at the very least |
|
ok, reasonable |
MarkSuckerberg
requested changes
May 3, 2023
|
what the hell is that linter fail |
|
It's over. |
|
NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Map Change
This reverts commit e6a8fbf.
github-actions
bot
removed
Map Change
Conflicts: code/__DEFINES/misc.dm code/__DEFINES/mobs.dm code/__DEFINES/traits.dm code/__HELPERS/mobs.dm code/datums/datum.dm code/game/objects/items.dm code/modules/client/preferences.dm code/modules/client/preferences_savefile.dm code/modules/mob/living/carbon/human/species_types/dwarves.dm code/modules/mob/living/carbon/human/species_types/humans.dm code/modules/mob/living/carbon/human/species_types/lizardpeople.dm code/modules/mob/living/carbon/human/update_icons.dm
|
This is gonna sit until a solution is found which might be forever |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
thgvr
changed the title
|
One day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Shortest --> Tallest
Makes pref height look better
Dwarf mutation is even smaller than Shortest.
Why It's Good For The Game
Better looking height options.
Changelog
🆑 Thgvr, Melbert, That REALLY Good Soda Flavor, FatFat, AndreyGusev
add: Height should now look better, with more options in prefs.
add: Dwarf mutation should look less horrible.
/🆑