Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overmap 4.6: Anomalous Activity #1991

Merged
merged 51 commits into from
Jun 30, 2023

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented May 29, 2023

About The Pull Request

dreamseeker_kHkMNbvOhX.mp4

Anomalies will now spawn on planets and remain static there, posing a passive threat to anyone who comes across them. If you're feeling daring, you can use an analyzer and signaller, or an anomaly neutralizer, to harvest their cores, and put them in an R&D console for research points.

Anomaly effects have also been expanded, you'll have to find out how in game though.

As a side effect to make bluespace anomalies work, removes the noteleport flag on planets

Why It's Good For The Game

More exploration content

Changelog

🆑 Bjarl, Ghilker, Comyx, Assorted /tg/ contributors
add: anomalies will now randomly spawn on planets
add: bioscrambler anomalies, they randomly change your organs and bodyparts
add: hallucination anomalies, they cause hallucinations
add: big anomalies, they're like normal anomalies but big.
fix: disk renaming should only work with pens now
/:cl:

@Erikafox Erikafox requested a review from a team as a code owner May 29, 2023 00:34
@github-actions github-actions bot added Code change Watch something violently break. DME Edit Sprites A bikeshed full of soulless bikes. labels May 29, 2023
@Erikafox
Copy link
Contributor Author

further proof as to why I should not be allowed to code.

@Erikafox
Copy link
Contributor Author

Erikafox commented May 29, 2023

Things I forgot to do and need to do tomorrow:
Experiment with size more
make bioscramblers give a few status effects so you have an indication of what's happening
unfucker bioscrambler clone damage

what I might do:
Subtype all the anomalies to be /planetary and restore original wandering behavior to the main types
make anomalies move in an area around their spawn tile (I would need help figuring this out)

@Erikafox Erikafox requested a review from MarkSuckerberg as a code owner May 29, 2023 17:50
@Erikafox Erikafox changed the title Anomalous Activity Overmap 4.6: Anomalous Activity May 30, 2023
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites are fine, theyre from tg

maybe make the bioscrambler either rarer or not do the effects immediatly, they could be hidden behind something and someone could get messed up with long term effects without realizing there was a bioscrambler nearby? maybe take this with a grain of salt since im just a spritetainer

@Erikafox
Copy link
Contributor Author

I can donk it down so that you just get the status effects at a long range. That's probably better for balance anyways

@thgvr
Copy link
Member

thgvr commented May 30, 2023

dunno about the bioscrambler anomaly

@Erikafox
Copy link
Contributor Author

I'm gonna cut it and whip up a few more anomalies to diversify the pool

@Erikafox Erikafox marked this pull request as draft May 31, 2023 19:07
@goober3
Copy link
Member

goober3 commented Jun 1, 2023

image
hi erika i think you should maybe remove bluespace anomalies

@Erikafox
Copy link
Contributor Author

Erikafox commented Jun 1, 2023

I would specify why that isn't a good reason but we're still in round

basically: skill issue

code/modules/mob/living/carbon/status_procs.dm Outdated Show resolved Hide resolved
code/modules/research/rdconsole.dm Outdated Show resolved Hide resolved
code/modules/research/rdconsole.dm Outdated Show resolved Hide resolved
code/modules/research/rdconsole.dm Outdated Show resolved Hide resolved
code/game/objects/effects/anomalies/anomalies_vortex.dm Outdated Show resolved Hide resolved
code/game/objects/effects/anomalies/anomalies_bluespace.dm Outdated Show resolved Hide resolved
Co-authored-by: Mark Suckerberg <[email protected]>
Signed-off-by: Bjarl <[email protected]>
@github-actions github-actions bot requested a review from MarkSuckerberg June 27, 2023 01:22
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit

@MarkSuckerberg
Copy link
Member

oop

@Erikafox
Copy link
Contributor Author

AUGH

@github-actions github-actions bot requested a review from MarkSuckerberg June 27, 2023 01:49
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Jun 30, 2023
Merged via the queue into shiptest-ss13:master with commit 9ae4873 Jun 30, 2023
@Erikafox Erikafox deleted the planetary-anomalies branch October 29, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Sound USSR Anthem 2.66 MB file. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants