Removes SSJob (Brutally) #2127
Merged
Removes SSJob (Brutally) #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DME Edit
Admin
|
amazing name |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MarkSuckerberg
force-pushed
the
how-deep-does-the-rabbit-hole-go
branch
from
7d399bb to
a21a946
Compare
|
honestly forgot I even did this lmao |
|
Finish it already or Im putting you on the lizard stretcher |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Config
MarkSuckerberg
force-pushed
the
how-deep-does-the-rabbit-hole-go
branch
from
a10f15a to
f7cca49
Compare
github-actions
bot
added
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
SSJob is a vestigial part of the codebase, quickly bandaged to support our system. I've slowly stripped it away, but I left it in because it was rooted deeply in a few pieces of code. Today I finally just decided to rip that out too, since SSjob is continuing to break things to this day.
Removes:
Adds:
Why It's Good For The Game
SSJob breaks a lot, and just isn't used. This is another piece of global state that's being removed and replaced with something that better fits us.
Changelog
🆑
del: Gang and revs gamemode (the gear remains)
admin: Removes SSjob, occupations are now stored in a global list
/:cl: