Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSlag_switch from /tg/ #2133

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

MarkSuckerberg
Copy link
Member

@MarkSuckerberg MarkSuckerberg commented Jul 6, 2023

About The Pull Request

Ports:

and adds a few shiptest-specific toggles as well to better take advantage of the system.

Why It's Good For The Game

Recently lag has become a bit more of an issue here, and I think I would rather we be able to play than force ourselves to suffer while we slowly work on perf improvements.

Changelog

🆑
admin: Adds lag switch toggles from /tg/, ONLY use them when the lag becomes unbearable!
/:cl:

Wayland-Smithy and others added 3 commits July 5, 2023 20:49
Requested by oranges and inspired by the upcoming event. A new subsyetem, non-processing (for now), aimed at providing some toggle switches that can be flipped as a last ditch effort to save some CPU cycles by sacrificing some non-critical mechanics. Below you can see each individual toggle.

Screenshot of the admin panel:
image
Surely there are more opportunities for toggles I missed, but adding new ones is not very difficult at all.
Why It's Good For The Game

Better performance during extreme pop, I hope.
Changelog

cl
code: Introduces the Lag Switch subsystem for when a smoother experience is worth trading a few bells and whistles for. Performance enhancement measures can be togged by admins with the Show Lag Switches admin verb or enabled automatically at a pop amount set via config.
config: Added a new config var: number/auto_lag_switch_pop
…62999)

At the last Toolbox Tournament, @MrStonedOne pointed out some big performance consumers. Some are disablable through easy means, but others were not. This adds two easy ones to the mix.
@github-actions github-actions bot added Config Watch us shake head admins violently until this gets merged. DME Edit Admin They do it for free. Code change Watch something violently break. labels Jul 6, 2023
@Erikafox
Copy link
Contributor

Erikafox commented Jul 6, 2023

lag is solved forever

@MarkSuckerberg
Copy link
Member Author

so true

@MarkSuckerberg MarkSuckerberg changed the title SSlag_switgh from /tg/ SSlag_switch from /tg/ Jul 6, 2023
@Sun-Soaked
Copy link
Member

image
no way I just saw this one while looking for atom comsigs

@MarkSuckerberg
Copy link
Member Author

we do a little lag mitigation

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Jul 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 21, 2023
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jul 21, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MarkSuckerberg MarkSuckerberg requested review from a team as code owners August 11, 2023 01:58
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. TGUI Sound USSR Anthem 2.66 MB file. Dependencies GitHub Our very own Babylon. and removed Merge Conflict Use Git Hooks, you're welcome. labels Aug 11, 2023
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Aug 11, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Sound USSR Anthem 2.66 MB file. Dependencies GitHub Our very own Babylon. labels Aug 11, 2023
@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. and removed Merge Conflict Use Git Hooks, you're welcome. labels Aug 11, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 13, 2023
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Sep 13, 2023
Merged via the queue into shiptest-ss13:master with commit 48616ec Sep 13, 2023
@MarkSuckerberg MarkSuckerberg deleted the lag-mitigation branch September 13, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin They do it for free. Code change Watch something violently break. Config Watch us shake head admins violently until this gets merged. DME Edit TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants