Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dwayne Mark.II #2216

Closed
wants to merge 12 commits into from
Closed

Dwayne Mark.II #2216

wants to merge 12 commits into from

Conversation

rye-rice
Copy link
Member

About The Pull Request

Finishes the dwayne update started in the any% walls pr. I never finished it there because there were 100+ maps to deal with so this could wait.

Also adds the Mark.I, certain reptils might recognize it

Screenshot_6705

Screenshot_6704

Why It's Good For The Game

I fucking love this ship, it needs love, ship #1 should live

Changelog

🆑
add: Dwayne MK.I
tweak: The Dwayne Mark.II has been updated
/:cl:

@rye-rice rye-rice requested a review from a team as a code owner July 30, 2023 21:45
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jul 30, 2023
@goober3
Copy link
Member

goober3 commented Jul 30, 2023

no!!! my dwayne shrinklet PR!!!

@MarkSuckerberg
Copy link
Member

subshuttles are stored in the dwayne <3333

Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

wire fuckies

image

while creative, DONT do the bunk beds without proper sprites for it (and the code necessary)
players wont really be able to use it well. (also light on poster)

image

this is quirky (not asking you to change anything)

image

please add some blast doors for the engines!

image

poster light

@rye-rice
Copy link
Member Author

rye-rice commented Aug 2, 2023

@spockye, adressed requests, the posters were on the other side of the walls, but i changed their position anyways

@rye-rice rye-rice requested a review from spockye August 2, 2023 22:44
@spockye
Copy link
Contributor

spockye commented Aug 3, 2023

@spockye, adressed requests, the posters were on the other side of the walls, but i changed their position anyways

always good to leave some open wallspace in any case! (for players to add posters and whatnot, and to show off out beautiful walls)

i'll give you a new review once i've seen the ship in action. Good work with it!

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Aug 18, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@spockye
Copy link
Contributor

spockye commented Sep 10, 2023

get checks to pass, and i'll TM this

@rye-rice
Copy link
Member Author

ough

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 16, 2023
@rye-rice
Copy link
Member Author

checks pass, yayay @spockye

@spockye
Copy link
Contributor

spockye commented Sep 17, 2023

checks pass, yayay @spockye

*un-passes your checks

Remember, no ship versions. Remove the Alt!

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 15, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. and removed Merge Conflict Use Git Hooks, you're welcome. labels Oct 16, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you might have doubled your atmos piping. Please fix your atmosery.

@rye-rice
Copy link
Member Author

rye-rice commented Dec 3, 2023

updating this to master corrupts the map, ah well

@rye-rice rye-rice closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Merge Conflict Use Git Hooks, you're welcome.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants