Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildmode & Supply Pod Ports #2272

Merged
merged 13 commits into from
Sep 13, 2023
Merged

Buildmode & Supply Pod Ports #2272

merged 13 commits into from
Sep 13, 2023

Conversation

thgvr
Copy link
Member

@thgvr thgvr commented Aug 10, 2023 •
edited
Loading

@thgvr thgvr requested a review from a team as a code owner August 10, 2023 09:03
@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Aug 10, 2023
@github-actions github-actions bot added Admin They do it for free. TGUI labels Aug 10, 2023
@thgvr thgvr requested a review from a team as a code owner August 10, 2023 10:37
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Aug 10, 2023
@thgvr
Copy link
Member Author

thgvr commented Aug 10, 2023

Can't test pods in local host because it doesn't load centcom :(

@thgvr thgvr changed the title Buildmode Ports Buildmode & Supply Pod Ports Aug 11, 2023
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Aug 12, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

rye-rice
rye-rice approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Aug 18, 2023
@rye-rice
Copy link
Member

rye-rice commented Sep 5, 2023

image
fix linters

@thgvr
Copy link
Member Author

thgvr commented Sep 6, 2023

I have no idea what that lint error means

@rye-rice
Copy link
Member

rye-rice commented Sep 6, 2023

remove "var/" from the procs

@Geoengi Geoengi mentioned this pull request Sep 10, 2023
Closed
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Sep 13, 2023
Merged via the queue into shiptest-ss13:master with commit 58b63d6 Sep 13, 2023
shiptest-server pushed a commit that referenced this pull request Sep 13, 2023
@actions-user
Automatic changelog generation for PR #2272 [ci skip]
663deef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rye-rice rye-rice rye-rice approved these changes

Assignees
No one assigned
Labels
Admin They do it for free. Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. TGUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thgvr @rye-rice @MarkSuckerberg