World Icons #2279
World Icons #2279
Conversation
world icons
github-actions
bot
added
DME Edit
Sprites
|
fuck you linters |
|
: D |
I mean it works! -Spritainers want more sprites done before it's formally implemented in -Tmt had some issues with the implementation, which is a little odd because it comes from a server trying to have code parity with /TG/ |
I was so high when I wrote this :)))
haha oops
|
sorry for not looking at this in very long. the reason i have issues with the implementation is that it looks like it's implemented to minimize the # of lines you have to modify in an item's original file to add world sprites (why make it an element attached to the item instead of just base behavior on /obj/item?). that makes sense for a server that's trying to maintain parity with an upstream, but less so for us. regardless, so long as it's functional (and doesn't break when things get blood on them), i'm fine with it |
|
ouaagh(mojave why.. .) |
|
Any luck with the overlay stuff? |
bad signal...
|
overlays now working, but at what cost? (don't look at the bottom of blood.dm) |
|
Pretty sure this just caused a bunch of items to randomly have no lighting and be on a really high sprite layer |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Sun-Soaked <[email protected]>
FalloutFalcon
added
Test Merged
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Ports world icons from Mojave 13. This is an element that allows for tiny, size-accurate versions of object sprites in a roundabout way. ~~Drafted since spritainers want more coverage before merging~~ UNDRAFTED by request of a spritainer. God weeps ### //MAKING A SUPER BASIC WORLD ICON IMPLEMENTATION GUIDE: FOR REAL. NO VIRUS. 100% ORGANIC// - Place the Element in an Init below The Item In Question `/obj/item/Initialize()` ` . = ..()` ` AddElement(/datum/element/world_icon, null, icon, 'icon')` - Fill in info. Put the ORIGINAL ICON in the addelement's `'icon'` slot (yeah, this element layers the "original" sprite on top of the worldicon one, using it as the default. It just be like that sometimes) `/obj/item/kitchen/knife/combat/Initialize()` ` . = ..()` ` AddElement(/datum/element/world_icon, null, icon, 'icons/obj/kitchen.dmi')` - Put the directory to your NEW, WORLD ICON in the item's normal icon var `icon = 'icons/obj/world/melee.dmi'` The world icon and icon adjustment vars on obj/item should allow for implementation in places where an object's Icon has to frequently change. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Just a little guy <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: World icon element. add: World icons for combat knives. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Sun-Soaked <[email protected]> Co-authored-by: Sun-Soaked <[email protected]> Co-authored-by: FalloutFalcon <[email protected]>
About The Pull Request
Ports world icons from Mojave 13.
This is an element that allows for tiny, size-accurate versions of object sprites in a roundabout way.
Drafted since spritainers want more coverage before mergingUNDRAFTED by request of a spritainer. God weeps
//MAKING A SUPER BASIC WORLD ICON IMPLEMENTATION GUIDE: FOR REAL. NO VIRUS. 100% ORGANIC//
/obj/item/Initialize(). = ..()AddElement(/datum/element/world_icon, null, icon, 'icon')'icon'slot(yeah, this element layers the "original" sprite on top of the worldicon one, using it as the default. It just be like that sometimes)
/obj/item/kitchen/knife/combat/Initialize(). = ..()AddElement(/datum/element/world_icon, null, icon, 'icons/obj/kitchen.dmi')icon = 'icons/obj/world/melee.dmi'The world icon and icon adjustment vars on obj/item should allow for implementation in places where an object's Icon has to frequently change.
Why It's Good For The Game
Just a little guy
Changelog
🆑
add: World icon element.
add: World icons for combat knives.
/:cl: