Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes some issues on the box and li tieguai class ships #2303

Merged
merged 19 commits into from
Oct 15, 2023

Conversation

BarteG44
Copy link
Contributor

About The Pull Request

-fixed misplaced light switches
-fixed misplaced fire extinguisher cabinets
-got rid of the errors from the li tieg's intern closet
-fixed some areas on both ships
-fixed some aesthetics that got messed up when the floor sprites got changed
-gave the li tieg an anesthetic closet
-changed the box bathroom layout for like the 4th time

Why It's Good For The Game

ship maintenance is good i think

Changelog

🆑
fix: fixed a few issues with the Box class
fix: fixed a few issues with the Li-tieguai class
/:cl:

@BarteG44 BarteG44 requested a review from a team as a code owner August 20, 2023 19:41
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Aug 20, 2023
Copy link
Member

@goober3 goober3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
this should be an air canister.

image
why is this scrubber connected to a plasma tank!

image
move this light fixture to the opposite wall and replace the walls over the layer adapters with windows. wall pipes should be avoided wherever possible.

image
image
light fixtures shouldnt be placed over posters!!

image
and posters should be pixel shifted onto walls, like wallmounts.

image
as a general rule. try to place wallmounts, like light switches, in places where they could feasibly be reached without much effort. here, just move your light switch over to the right, if you want to keep the theme with APC-adjacent light switches.

image
get this Got Damn plant out of the way. or move the air alarm

image
move this light switch down 2 pixels.

li-tieguai review. Coming Soon

Copy link
Member

@goober3 goober3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
move the fire alarm here to the south wall, next to the techfab.

image
light fixtures on posters!!!!

image
move all of these north-facing light switches up 3 pixels.

guod job!!!

@BarteG44
Copy link
Contributor Author

why is this scrubber connected to a plasma tank!

the scrubber is clearly connected to a red pipe and the tank to an orange one

and posters should be pixel shifted onto walls, like wallmounts.

this was a conscious choice from before the wallening - fixed

move this light fixture to the opposite wall and replace the walls over the layer adapters with windows. wall pipes should be avoided wherever possible.

this got approved by erica before (most of these were actually approved by them since i pretty much only touched the switches)

light fixtures shouldnt be placed over posters!!

that first poster is on the opposite side of the wall

move this light switch down 2 pixels.

check it in game. APCs for whatever reason get shifted a few pixels in game from where they are in mapping

fixed the rest

@BarteG44
Copy link
Contributor Author

move the fire alarm here to the south wall, next to the techfab.

that wall's already crowded with the light switch and APC

light fixtures on posters!!!!

those are ancient - fixed

@goober3
Copy link
Member

goober3 commented Aug 20, 2023

the scrubber is clearly connected to a red pipe and the tank to an orange one

image

this got approved by erica before (most of these were actually approved by them since i pretty much only touched the switches)

and wallpipes are banned now! go fix it mapper boy

that wall's already crowded with the light switch and APC

i mean!! next to the APC, not on the same part of the wall as the APC. better than under the wall locker.

@BarteG44
Copy link
Contributor Author

TM this NOW
i've adressed the requests long ago

@BarteG44
Copy link
Contributor Author

BarteG44 commented Sep 6, 2023

would be nice if this got TMd this year

@spockye
Copy link
Contributor

spockye commented Sep 17, 2023

would be nice if this got TMd this year

unfuck your tests and I'll CONSIDER tm'ing this next year

@BarteG44
Copy link
Contributor Author

BarteG44 commented Oct 14, 2023

unfuck your tests and I'll CONSIDER tm'ing this next year

image

the two month anniversary's coming

@goober3 goober3 enabled auto-merge October 15, 2023 15:07
@goober3 goober3 added this pull request to the merge queue Oct 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2023
@thgvr thgvr added this pull request to the merge queue Oct 15, 2023
Merged via the queue into shiptest-ss13:master with commit aeb6900 Oct 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants