Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaps the Skipper Heavy Cruiser #2344

Merged
merged 32 commits into from
Sep 26, 2023
Merged

Conversation

Zevotech
Copy link
Contributor

@Zevotech Zevotech commented Sep 8, 2023

About The Pull Request

I love the Skipper a lot, but it was getting kind of outdated in terms of mapping and had a slew of issues that made it harder to enjoy as time went on. This remap changes the footprint of the Skipper to have a smaller engineering segment and more room for the crew to move about and interact.

SDMM:
2023-09-14 02 49 11
The egriegious amounts of wallpipes have been removed, the internal affairs agent has their own room with privacy shutters to hold meetings, the cafeteria and crew area have been upgraded and engineering has been shrunk by about 30%.

Ingame:
image
The three engineer slots have been replaced with an atmos tech and an engineer. A cargo tech slot has been added to manage the cargo office and handle outpost purchases. There is also now a dedicated cook slot to occupy the new kitchen and bar.

Why It's Good For The Game

Ship maintaining. Also wallpipes, wallguns, the injector under a thruster and various other things aren't good for a map.

Changelog

🆑
add: Remaps the Skipper Heavy Cruiser
add: Adds an Atmos Tech, Cargo Tech and Cook job slot to the skipper
del: Removes two engineer slots from the skipper.
/:cl:

@Zevotech Zevotech requested a review from a team as a code owner September 8, 2023 19:31
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Sep 8, 2023
@Zevotech
Copy link
Contributor Author

Zevotech commented Sep 8, 2023

Alright, I'm calling this complete. Needs reviews from maptainers now.

Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

try adding some wooden linings here! might look pretty.
(good work with the table populating! looks like someone actually uses the place)
also, i do think the amount of weapons could be trimmed. i'd say remove atleast one of the laser guns

image

could use some contrast in here. mabye try changing the turfs around?

image

the blue is a bit painful imo. dont have to change it, if its just me


this is for sure an improvement. good work!
i'll see about TMing this next uptime

@Zevotech
Copy link
Contributor Author

pls tm i NEED to test this

@Apogee-dev
Copy link
Contributor

Apogee-dev commented Sep 14, 2023

You might want to mess around with the hallway outside of the kitchen a little bit more, actually. The dining table takes up a lot of space for an area that pulls double duty as a primary entrance/exit to the ship thanks to that airlock. I'd suggest giving the big table the axe and leaving it with the cafe bar and the small 2-seater table for seating options so there's a bit of room to maneuver coming out of the airlock.

@Zevotech
Copy link
Contributor Author

You might want to mess around with the hallway outside of the kitchen a little bit more, actually.

Shrunk the big table so theres more space to move around it.

@Draggeru
Copy link
Contributor

Draggeru commented Sep 14, 2023

The bridge does not have a holopad anymore, I don't think I need to explain why such is an issue

@Zevotech
Copy link
Contributor Author

The bridge does not have a holopad anymore, I don't think I need to explain why such is an issue

image
KILL. (give me a minute to update the images nerd)

@Draggeru
Copy link
Contributor

The bridge does not have a holopad anymore, I don't think I need to explain why such is an issue

image KILL. (give me a minute to update the images nerd)

I CANT READ OH GOD.

@Zevotech
Copy link
Contributor Author

images updated smileyface

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 14, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 15, 2023
@Zevotech
Copy link
Contributor Author

merge conflict removed, checking for corruptions then its ready for re-tm

@spockye
Copy link
Contributor

spockye commented Sep 22, 2023

Good work

@spockye spockye added this pull request to the merge queue Sep 22, 2023
@Zevotech
Copy link
Contributor Author

Good work

:DDDDDDDD

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2023
@goober3
Copy link
Member

goober3 commented Sep 26, 2023

epic fail

@goober3 goober3 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into shiptest-ss13:master with commit f1edc03 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants