Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new foodtype, GORE, split from GROSS. Shuffles species food preferences. #2359

Merged

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Sep 18, 2023

Ports:

About The Pull Request

Very shrimple 🦐 PR.(contains no shrimp)

Adds a new foodtype GORE, split from the GROSS foodtype. A newfood PR thats rather simple, but also important to prepare for future changes.

The tag is meant to represent things that "are visibly from a corpse or an organ", while the GROSS tag now represents "things which are rotten or otherwise inedible".

This will be mostly effect lizards. They were meant to like gross, meaty things like some of the raw meats, but it doesnt make sense for this also to encompass gross things like Burgers with baseballs as a primary ingredient,

While this will lessen the food lizards will enjoy, it will also widen the food Kepori and Arachnids enjoy. Both are similarly carnivorous, so for consistency's sake, why not?

Additionally, I took a bit to generally clean up Shiptests species food preferences, adding missing disliked or liked food where I thought it was appropriate. I included comments with most of my changes that should relay my general ideas about what makes sense and what doesn't.

I do, of course, invite challenges to any of the liked or disliked foods I've altered that you think could be better.

Why It's Good For The Game

Lizards are the main target of this, but it should improve the food gameplay of other species as well. Specifically should open up more food for Kepori and Arachnids.

Lizards and other species being memes for being able to eat half of all unique food because they like raw and gross is really dumb.

If you chew on inedible food, mr lizard, you will regret it.

Changelog

🆑 RKz, Jacquerel
add: New foodtype, GORE. Split from GROSS, GORE foodtype will be replacing it where the food in particular resembles a corpse or organ. GROSS should only apply to inedible or rotting foods. (baseball burgers)
balance: 'Gore' is disliked by Humans and Toxic to Moths. However, Gore is liked by Lizards, Arachnids, Kepori, Slimepeople and Flies. Lizards no longer like 'gross' food.
balance: All butchered player species are considered to be gore, only preferred by Lizards, Arachnids, Kepori, Slimepeople and Flies. If you like the taste of your fellow(or rival) crew, prepare accordingly.
balance: Moved food preferences around to make more sense with the current system. Nothing drastic, but species liked foods should be much more immersive in general.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Sep 18, 2023
@Tsar-Salat Tsar-Salat marked this pull request as ready for review September 18, 2023 05:05
@Valorium-RB
Copy link

Small request: could you make the Assorted Salted Offal ration from the Rations PR also have the GORE food type? Really happy this is being added.

@Tsar-Salat
Copy link
Contributor Author

Assorted Salted Offal

"Here... you'll need something to eat out there." -Pearson

"Assorted, Salted Offal... Starving would be preferable." -Arthur

@Valorium-RB
Copy link

Assorted Salted Offal

"Here... you'll need something to eat out there." -Pearson

"Assorted, Salted Offal... Starving would be preferable." -Arthur

I am allowed exactly one (1) reference. As a treat.

Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

can't wait to eat bees

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Sep 19, 2023
Merged via the queue into shiptest-ss13:master with commit 4f5845a Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants