Adds a crashed pubby as a sand world ruin #2363
Conversation
github-actions
bot
added
Config
|
Fixed all conflicts awaiting review by a maptainer |
There was a problem hiding this comment.
light on locker
unrotated button. mabye make things a bit more thrown about in the ship, instead of being on tables? would give it a more unkept feel
light on apc
light on locker, light on newscaster
light on airalarm
ruin has 6 apc's, yet one area! this will cause bugs. (remove all but one apc)
Remove the autosurgeon. while it's a cool item, its a tad too good for the challenge this ruin poses. (shouldn't really be used at all, anywhere)
good work!
|
Changes made awaiting review again |
_maps/RandomRuins/SandRuins/whitesands_surface_pubbyslopcrash.dmm
Outdated
Show resolved
Hide resolved
|
|
|
|
|
|
There was a problem hiding this comment.
please beef up these rocks around the corners a little. one-wide mountains will look odd -- and reveal structures behind them, as they do not blend with walls.
replace these sand turfs with /lit variants -- or replace them with rock turfs, if you want to make this look like a cave.
good job! we'll get this test merged soon.
|
Requested changes made this pull request is ready to be merged once the tests are run then correct? |
|
essentially, yes. |
|
Checks are all green time to test! |
|
There are still podlocks and blast doors under the rocks in the pod bay area. |
|
Please add a screenshot from SDMM with the areas on. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
fix the conflict, and i'll see about merging this! |
Screen shot added to PR |
github-actions
bot
removed
Merge Conflict
There was a problem hiding this comment.
take a look at the rest of our crash maps and see how they handle crashes. Usually you can see that they landed, pushing up a crater, as opposed to being entombed in rock.
Once you do that, you can scatter some more debris around and create more of an "impact" in your story.
The base idea is sound, if not exciting. Not every ruin needs to be some world shattering revelation though, so I happen to like this.
|
I have a few more nitpicks on this, but seeing as this has been open since september. marged. |
Adds a crashed pubby as a sand world ruin (shiptest-ss13#2363)
## About The Pull Request As per the request of @Latentish This PR tweaks the recently merged (#2363) Crashed Pubby Ruin. The shape of the crash area should now be more realistic. Several issues have been fixed, as well.    ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog ๐ tweak: The Crashed Pubby Ruin has been tweaked slightly. fix: Fixed a floating wallmount in the Crashed Pubby Ruin. /๐
## About The Pull Request As per the request of @Latentish This PR tweaks the recently merged (shiptest-ss13#2363) Crashed Pubby Ruin. The shape of the crash area should now be more realistic. Several issues have been fixed, as well.    ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog ๐ tweak: The Crashed Pubby Ruin has been tweaked slightly. fix: Fixed a floating wallmount in the Crashed Pubby Ruin. /๐
About The Pull Request
Adds a new pubby crash map along with the requisite area and ruin codes
Why It's Good For The Game
It adds another ruin... this is a good thing
Changelog
๐ Immortalartisan
add: A new sandworld ruin based on deprecated ship pubby
/:cl:
SDMM view with areas