Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rations 2 Electric Boogalo #2373

Merged
merged 13 commits into from
Oct 10, 2023
Merged

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Sep 23, 2023

About The Pull Request

Fixing all the things wrong with the first ration pr since it got merged without a test!
If anyone has any issues with rations I'm fixing them here hopefully.

  • Better explain ration heaters.
  • Make ration heaters send messages to chat about heating.
  • Stop rations from acting like beakers and splashing.
  • Make powder packs work on reagent containers.
  • Make the ration types more clear.
  • You are not allowed to munch on powder/liquid
  • Make some side dishes heat-able
  • Heaters are meant to have more then 1 use
  • Ration heater hard deleting

A few other small fixes not worth mentioning

Why It's Good For The Game

Fixing bugs is a pretty good idea!

Changelog

🆑
fix: fixed multiple bugs and oversights with rations
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Sep 23, 2023
@FalloutFalcon FalloutFalcon marked this pull request as ready for review September 30, 2023 20:16
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my name is latency and i approve this message

@ZephyrTFA ZephyrTFA added this pull request to the merge queue Oct 10, 2023
@ZephyrTFA
Copy link
Member

I pressed a button, it did something

Merged via the queue into shiptest-ss13:master with commit 0dee1ef Oct 10, 2023
10 checks passed
@FalloutFalcon FalloutFalcon deleted the ration2 branch December 18, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants