-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Komodo boot and baggage update. #2375
Conversation
Can you please clean up the changelog, it doesn't make much sense as is |
I... listed what was changed and where. |
what they mean is to specify the changes are to the komodo map. in the big changelog they'll end up looking like general changes. |
fax machine's on the wrong tile, fixing that
right. cleaned up the change log and someone pointed out an issue with the fax machine placement. This SHOULD be the final revision for now. |
fix checks please! |
all checks green across the board after severe prodding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. sorry for the wait. i'll get this TM'd next uptime.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Please fix your merge conflicts so we can tm this. |
screaming internally right now
I am honestly at a loss as to why the github action bot gave it the merge conflict label. 1c94f92 was completely fine. I don't have write access to resolve the conflict and there are no problems on my end when launching it via a private server. VSC and github desktop aren't reporting issues either. I'm KIND of stuck now... |
Hi there, Your merge conflicts are because the |
green across the board once more. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About The Pull Request
This started as an effort to address the over abundance of jackboots (a filthy nanotrasen product!) in place of the faction neutral combat boot on the syndicate warship.
And then I noticed a misplaced fire extinguisher cabinet in the bar. A broken icon state in the captain's locker. a light tube placed ON a defibrillator wallmount...
Why It's Good For The Game
misplaced, broken or even mispathed objects are awful. This PR addresses quite a lot of that and provides numerous SMALL adjustments to the komodo-class vessel.
for example, this is the armory before I addressed it.
and this is after.
Changelog
🆑
tweak: komodo medbay had the actual and useless cyborg limbs replaced with prosthetics
tweak: light tubes, fire extinguisher cabinets, apc/air alarm placement and light switches have had their relative positioning across the komodo changed for a consistent look and to reduce floating/mapping sins.
fix: armor/vest/security/hos was missing an icon_state path.
fix: changed shoes/jackboot with shoes/combat in the job_types\captain.dm file for the gorlex, cybersun and aclf command subtypes.
tweak: the fax machine on the komodo bridge was switched with the neighboring desk tile and objects that it was preventing easy access to.
/:cl: