[still cursed] Volumetric Storage #2377
Conversation
github-actions
bot
added
DME Edit
Sprites
-makes ui less bad -makes bigger objects fit in trash bags(it's a trash bag goofus)
|
shut up linters |
I am the trash man
huh??? huh? huh???
|
Is there much reason to make "volume" separate from "weight class"? |
|
is this in a tm ready state or is it silly |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
ooooooo you want to worko n this |
I grab the papers in front of me with my teeth and shake them around really fast Okay but seriously these are the two issues: -I wanted to do the "backpacks can only be opened inhand"/"duffels can only be opened from floor" thing, and the code I made for it is jank/doesn't work properly -The ui is still janky and flickers/overlaps. This is how it is on Cit as well, so I need to do a deep dive into how the UI works to see even what the problem is, and then start to think of a solution |
|
I'd leave the inventory access stuff for another pr, it's important enough to warrant it |
|
Fix your lints |
linters were fixed lizard boy |
|
maybe we can tm it........ |
video james
|
confetti (tired voice) |
|
god |
Sun-Soaked
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Backpacks and satchels have different storage space amounts despite them having the same move speed still, which I assume is an oversight. We tested this specifically with the captains satchel and explorer bag. |
|
Oops hand slipped and clicked merge on 20 prs my bad |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Revival of [This PR](shiptest-ss13#850) Back storage is now organized visually using volumetric objects of different sizes, like bay. This will require testing and balancing, as well as potential re-weighting, since the default code allows much larger objects to be placed in storage(albiet taking up a whole lot of space.) So this is a draft for now Also ports unique trash bag behavior May implement unique behavior for different storage objects, also like on bay. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Sudie wanted me to revive this <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Volumetric storage on backpacks. add: trash bags now have more storage space, but only make a small amount of their contents accessible at any given time. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Sun-Soaked <[email protected]>
About The Pull Request
Revival of This PR
Back storage is now organized visually using volumetric objects of different sizes, like bay.
This will require testing and balancing, as well as potential re-weighting, since the default code allows much larger objects to be placed in storage(albiet taking up a whole lot of space.)
So this is a draft for now
Also ports unique trash bag behavior
May implement unique behavior for different storage objects, also like on bay.
Why It's Good For The Game
Sudie wanted me to revive this
Changelog
🆑
add: Volumetric storage on backpacks.
add: trash bags now have more storage space, but only make a small amount of their contents accessible at any given time.
/:cl: