-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Rockplanet Ruin: The Abandoned Shipping Dock (Redone Layout) #2393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviews addressed and added an areas-on picture. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there's a decent amount of loot for what is not a decent amount of threat, specially around the supposedly-secure areas where someone with a toolbox can just smash the doors open, the beartraps can be just picked up by players and the landmines are blinking. i do tend to lean towards more funny kill the player ruins and this is my opinion, but try and find some more traps? i don't know, some more elaborate stuff like figuring out how to detonate a pile of IEDs
…to rockruinsnew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put some scattered rocks, glass shards, and debris around the broken solar arrays, get some storytelling on how they've been degraded / broken
Exterior areas should be using the /explored type of the planet's main area. This allows weather to happen. We like weather
is this a stray decal? Also please make a percent chance mech spawner so it's not always gonna be there.
people decay... but they might've left something... leave a hat or something funny. (Think what doesn't decay into nothing, metals usually).
Don't include the firing pins, in fact, I would even say to subtype the guns to not start with any. This will drive players to the outpost so they can use their cool new loot.
who keeps sending these empty crates, give htem something, even if it's minor.
There should be some gas masks / emergency internals scattered around the place.
Seems mostly fine but will benefit from the detail pass.
Updated. |
i'd like to see this TM'd for a round or two more before we merge this. |
TM this sometime and ping me when it is so I can test it. |
drafting until #2759 is done because i really want to add those new mines to this to make it higher threat. |
w aw aw aw awa w a wa wa |
Done !!!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's time to pull this ruin out of forever purgatory.
railings are notoriously difficult to climb over from the inside. add some gaps here so players can access this spot easily. do this for the other railing enclosures too.
this barricade feels odd. either make it cursed and place the barricades on top of each other, or have one or the other here.
make this windoor a regular airlock or i'll sic thgvr on you.
this doesn't seem to have any major issues. i'll try and bribe someone to get this in the TM list tonight.
yay yay yippee!! im free !! |
…ptest-ss13#2393) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request SDMM: ![StrongDMM-2024-04-21 04 36 46](https://github.com/shiptest-ss13/Shiptest/assets/95449138/79f98fe2-47ab-4c5a-a063-c5ef42902c15) ![StrongDMM-2024-04-21 04 36 49](https://github.com/shiptest-ss13/Shiptest/assets/95449138/fec77936-0dd1-485f-8c5e-fa68b9ec5b91) Ingame: ![image](https://github.com/shiptest-ss13/Shiptest/assets/95449138/f217f1cf-70da-4c3b-b3a9-8914989e7ea6) Adds a new ruin for rockplanet. Its an abandoned shipping dock previously used by traders and smugglers in the sector. It has since fallen into disrepair, forgotten by its owners. Malicious scavengers or other groups have since filled the place with devious traps, hoping to catch their competition (You) off guard. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game more ruins that arent free rnd or gamer loot are good please map more ruins <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: rockplanet_shippingdock.dmm and associated code /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: spockye <[email protected]>
About The Pull Request
SDMM:
Ingame:
Adds a new ruin for rockplanet. Its an abandoned shipping dock previously used by traders and smugglers in the sector. It has since fallen into disrepair, forgotten by its owners. Malicious scavengers or other groups have since filled the place with devious traps, hoping to catch their competition (You) off guard.
Why It's Good For The Game
more ruins that arent free rnd or gamer loot are good
please map more ruins
Changelog
🆑
add: rockplanet_shippingdock.dmm and associated code
/:cl: