ERT Minor Refactor, more ERTs, ERTs can now spawn on subshuttles #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
thgvr
requested changes
Nov 18, 2023
thgvr
approved these changes
Nov 18, 2023
|
cant wait for an event where the admins just spawn like 8 pills total, load them with syndie/NT ERTs, and send them out to battle to the death |
|
It seems fine in TMs but there's still some issues I believe with erts spawning at centcom. I'll take a thorough look this weekend. |
Co-authored-by: Mark Suckerberg <[email protected]> Signed-off-by: meem <[email protected]>
shiptest-server
pushed a commit
that referenced
this pull request
Dec 12, 2023
MysticalFaceLesS
added a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Dec 13, 2023
ERT Minor Refactor, more ERTs, ERTs can now spawn on subshuttles (shiptest-ss13#2395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#71348 and tgstation/tgstation#56345, with code adapted for Shiptest.
Also adds the following ERTs:
Why It's Good For The Game
adminbus funny
Changelog
🆑 Zonespace27, Ryll-Ryll, MeeMOfCourse
tweak: Admins can now spawn an unarmed horde of interns in addition to the old armed horde
tweak: Admins can toggle name randomization for ERT's, as well as if they'd like to be spawned in the briefing room at the time of creation
tweak: Admins can now force ERT's to pick the leader role from the most experienced candidates in terms of playtime
tweak: Menus like Create Response Team and Create Portal Storm now toggle boolean options when clicked, rather than open a popup window to select one of the two options
refactor: Centcom Officials are now a full subtype of ERT, rather than being a separate antagonist type with duplicated functionality
admin: ERTs can now have a custom shuttle that they can spawn on, on a toggle while creating said ERT.
admin: Shiptest-Specific ERTs, and respective files.
/:cl: