Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Icemoon, Ruin} The Crashed Holemaker #2413

Merged
merged 19 commits into from
Dec 16, 2023

Conversation

unit0016
Copy link
Contributor

@unit0016 unit0016 commented Oct 19, 2023

About The Pull Request

Adds a brand-new - well, new to shiptest - ruin to the Icemoon roster, focused on the service department.

It's flavored around being an incredibly old NT Spaceworks vessel that's been carved in half and crashed - what's present only being the fore of the ship. Being mainly service-focused, it's loot is pretty dry as is it's sole threat.
If more current-day mappers/balance-heads have any words about how to fluff out either of those pools a bit more with the screenshots below, lemme know. I'll listen well.

(Notarized loot summary removed as updating it was a pain in the ass, lmao.)

It strikes me as leaning on the underwhelming side from looking at the other ruins present here but we'll. See? I suppose? It's good practice for me in the whole, "making something I have memorized and that looks good normally look sicker ruined".

Pictures (All but SDMM Outdated)

Ignore that there's no rust, the firelocks are open here, and some stuff's knocked around, I was testing it prior to me tacking the rust on and took pics after running around it in-person.

image

image

StrongDMM View:

2023-11-09 15 02 20

Why It's Good For The Game

This isn't what I intended to do when I was like, "oh yeah, I have a goofy ahh downstream out of boredom, ya'll want some of our better ships" but w/e here it is anyways. Ya'll need ruins. I made (another) ruin.

Changelog

🆑
add: A new icemoon ruin has been added, should you be in need of service department goodies.
/:cl:

@unit0016 unit0016 requested a review from a team as a code owner October 19, 2023 20:29
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Oct 19, 2023
Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could probably use some less loot-intensive ruins
Not seeing any issues, I'll give it a TM Soonish!

Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a ruin catalogue entry.

@github-actions github-actions bot added the Config Watch us shake head admins violently until this gets merged. label Oct 28, 2023
@unit0016
Copy link
Contributor Author

Addressed

config/iceruinblacklist.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Config Watch us shake head admins violently until this gets merged. label Oct 28, 2023
@Latentish Latentish dismissed their stale review October 28, 2023 06:20

addressed

@Latentish
Copy link
Member

This seems like a good stash of loot for something with no real threats.. Also I think you could benefit from adding some exterior padding, some of the environment around it, so by default it doesn't spawn out in the open.

@unit0016
Copy link
Contributor Author

unit0016 commented Oct 30, 2023

This seems like a good stash of loot for something with no real threats..

I'll update this, but honestly, I really don't believe that it's the case.
Even ignoring that other pre-existing ruins are thousands times more egregious (As examples I can name off the top of my head from playing, see icemoon_surface_engioutpost.dmm's free lathe setup and full engineering kit for three people and jungle_surface_roommates.dmm for two 40 force highlander claymores), the two big ticket items are.. a bar setup (two bar dispensers, a reagent grinder, a maintenance booze-o-mat, a condimaster) - and a service protolathe*, which is more restricted than even the autolathe, save a few items that can't be moved over to an autolathe via a design disk and RND.

Everything else is either redundant or otherwise incredibly minor.

* NOT a techfab, to be clear. This can't print circuit boards. Yes, they look IDENTICAL. It annoys the hell out of me too!! I tried to fix this on /tg/ but a conflict happened and I got lazy.

Also I think you could benefit from adding some exterior padding, some of the environment around it, so by default it doesn't spawn out in the open.

Going to be taking this advice in partially the opposite direction tbh. Thinking on it more I want only the south side to be exposed by default.

Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very detail-sparse for a crash map. Please include scrap and debris trailing the crash site.
image
subtype this so it has proper atmos please. Active turfs bad.
image
ditto

Could use some creatures / definition stuff inside to show that it's been there a bit, and didn't experience the joys of atmospheric re-entry 20 minutes ago. Blown in snow piles, corpses, stuff like that.

@unit0016
Copy link
Contributor Author

unit0016 commented Nov 8, 2023

No updatepaths script, cringe

I miss when I made a ##path define for atmos comp but that shit isn't gonna be possible here thanks to future(tm) plans(tm). Next up: custom corpse spawners. the monkey's paw or something, you tell me.
Good god man, the tooling for testing ruins is super unfriendly. Map template place is really not the kind of tool I should be relying on. Also, did you know that /ruin/powered doesn't mean it SUPPORTS power, but means that it actually has MAGIC power? what the fuck?? Who thought this was okay and who HURT them..
@unit0016 unit0016 requested a review from a team as a code owner November 8, 2023 20:03
@github-actions github-actions bot added the Sprites A bikeshed full of soulless bikes. label Nov 8, 2023
@unit0016
Copy link
Contributor Author

unit0016 commented Nov 8, 2023

Did all of that. In the process, the following items have been added to the ruin and thus it's.. "loot" ""pool"":

  • Two slags of corgi meat and a corgi hide
  • A microwave
  • A fueltank and mechanical toolbox
  • a KNIFE (no!!)
  • WOODDD. More wood! There's now enough for a baseball bat just lying around, but it's scattered.
  • A double bedsheet.
  • Brand spanking new mime and assistant husk corpse spawners. Also the generic corpse spawner icon has been redone to differentiate it a bit (purely because mob/landmarks.dmi had an icon state that didn't correspond to any job)

I was considering tacking on a pacman but decided against it last minute.

code/modules/awaymissions/corpse.dm Outdated Show resolved Hide resolved
awaiting feedback on if the dummy's good to keep
@Erikafox
Copy link
Contributor

Erikafox commented Nov 9, 2023

Did all of that. In the process, the following items have been added to the ruin and thus it's.. "loot" ""pool"":

* Two slags of corgi meat and a corgi hide

* A microwave

* A fueltank and mechanical toolbox

* a KNIFE (no!!)

* WOODDD. More wood! There's now enough for a baseball bat just lying around, but it's scattered.

* A double bedsheet.

* Brand spanking new mime and assistant husk corpse spawners. Also the generic corpse spawner icon has been redone to differentiate it a bit (purely because mob/landmarks.dmi had an icon state that didn't correspond to any job)

I was considering tacking on a pacman but decided against it last minute.

Go a little more wild with the debris and assorted random bullshit. Loot Pools are fake because most of this stuff is common enough anyways. Scatter around broken machinery bits so people can reassemble them, more wood, Just. More. It still feels weirdly empty to me.
I will duely inform you if it ends up being Too Much.

@unit0016
Copy link
Contributor Author

unit0016 commented Nov 9, 2023

Hokay, that should be most of the whitespace filled up?

@unit0016
Copy link
Contributor Author

Noticing MDB has an issue here where it shows the wrong icon state for chairs and chairs specifically. Weird!

Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna see how this plays out today.

@goober3 goober3 added this pull request to the merge queue Dec 16, 2023
@goober3
Copy link
Member

goober3 commented Dec 16, 2023

LGTM

Merged via the queue into shiptest-ss13:master with commit 247a4e0 Dec 16, 2023
10 checks passed
@unit0016 unit0016 deleted the tonight's-sosiest-loser branch December 16, 2023 20:44
MysticalFaceLesS added a commit to CeladonSS13/Shiptest that referenced this pull request Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants