Gun Safeties

[rye-rice]

About The Pull Request

Request from a friend

Adds gun safeties as I have seen people accidentally discharge their weapons one too many times

Adjusts tactical reload to 1 second rather than 1.2 seconds

overlay only appears in inventory

Why It's Good For The Game

Gun safety RP
Accidentally shooting someone happens far too many times to be just a 'skill issue'

Changelog

🆑
add: Adds gun safetys
balance: Tacitcal reload time adjusted from 1.2 seconds to 1 second
/:cl:

[Zevotech]

Could you make the click not audible/visible to nearby players? I know it might be like, a balance issue but I don't want my crewmate to know I nearly accidentally shot them while trying to examine them. Its awkward both IC and OOC.

[rye-rice]

Oh that's fair, ill go edit that then

Though that removes opportunities to scream at the miner for bad gun safety

[thgvr]

Dunno, I think the sound being audible is good

[rye-rice]

im pretty sure they're refering to the click when a gun fails to fire, not the toggle saftey click

[thgvr]

That's kinda funny tbh

[Zevotech]

Its a tossup between it being IC'ly reactible and it being an OOC mistake someone makes. Most of the time when someone gets shot accidentally both players acknowledge it was a misclick or positioning mistake and shrug it off IC without much fanfare to it. I just. dont like the awkwardness of someone hearing the click as i'm looking at them and having to see the internal calculation of "did he just try to shoot me or was it a mistake and should i acknowledge it IC"

[tmtmtl30]

I believe the safety typically blocks the trigger from moving, so it shouldn't make a click round when you attempt to fire with the safety on.

[thgvr]

I'm no gun nut but I'm fairly certain it varies

[thgvr]

Also, incredible, it fails the projectile unit test because the gun can't fire from having a safety on. Could be worth editing the unit test to disable the safety before firing?

[rye-rice]

LMAO, i think i can fix it, maybe

[Sun-Soaked]

That's kinda funny tbh

From a mechanical standpoint, you should ALWAYS get auditory feedback on your gun failing to fire. If it just happens in the forest without making a sound, it feels like a misinput and can get clunky quickly, especially if it's in a combat sitch

[thgvr]

Good to go?

[rye-rice]

Yes it is ready more or less

[thgvr]

Will review and merge tomorrow

[thgvr]

I didn't review it but Mark did

Complete