Mining Rework Part 1: First of his Name #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vile pinpointer code
|
Of course I accidentally screenshot a spelling mistake..... |
|
Ough, I forgot to mark this as a draft! |
Cleaned up some shitty code and improved the repair process
MarkSuckerberg
requested changes
Dec 12, 2023
Co-authored-by: Mark Suckerberg <[email protected]> Signed-off-by: BogCreature <[email protected]>
Co-authored-by: Mark Suckerberg <[email protected]> Signed-off-by: BogCreature <[email protected]>
Co-authored-by: Mark Suckerberg <[email protected]> Signed-off-by: BogCreature <[email protected]>
|
I'm tempted to merge this but I'll bother tmt to go over it, bit out of my range |
|
currently reviewing this; will finish looking at it tomorrow |
Co-authored-by: Mark Suckerberg <[email protected]> Signed-off-by: BogCreature <[email protected]>
tmtmtl30
requested changes
Feb 22, 2024
Clears out an unused variable, adjusts some drill defines, and fixes a description I accidentally changed
Enhanced ore vein comments, slightly improved scanner for loop, and bizzare and gormless mission drill writing improved
west3436
reviewed
Feb 23, 2024
west3436
reviewed
Feb 23, 2024
west3436
reviewed
Feb 23, 2024
west3436
reviewed
Feb 23, 2024
mine() is now mine() and mine_success() so there's less oddity with mission drills and ore veins now have a fallback plan for if there's no open adjacent turfs
Does away with the spawner component reference and converts it to use signals instead
Stops an extremely rare bug where if someone is on roughly the same position of an adjacent zlevel they would nudge the mob spawn modifier on the spawners
tmtmtl30
approved these changes
Feb 28, 2024
shiptest-server
pushed a commit
that referenced
this pull request
Feb 28, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Feb 28, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request In a vain attempt to make mining less boring and actually require more player engagement I have cobbled together the groundwork to a sizable reworking of the mining system from that thing you send out that one random crew member to go do for a couple minutes to a team-based activity focused around the use of specialized equipment. The gameplay loop for mining I envision within my mind's eye is one where most members of the ship's crew, even down to the engineers and medics, have to cooperate in order to properly secure large amounts of ore from dangerous environments, with most other non-mining ships needing to at least partially rely on mining ships to supply them with minerals. This PR specifically adds; ore veins (they use the same sprites as geysers pending a better one) that spawn on lava, sand, rock, and ice planets currently and at varying levels of difficulty and yeild, a drill with which to mine said veins, a scanner to find the aforementioned veins, and an outpost mission that is essentially just a mission to go drill ore veins but with money as the reward instead of ore. Oh and I also cut surface mineral spawn rates roughly in half pending a better gauge of the balance involved there. Here's the harrowing story of one such man who tried to use this drill with no armaments and no crew:    <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Mining in its current state is just kinda bad. It's boring to actually focus on doing and way too easy to just drown your ship in minerals. This PR would at bare minimum partially fix that. That's not to say it's perfect and doesn't need to be balanced and polished to hell and back, but it's a good first step I feel. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Ore veins and a drill to mine them with add: Mining based missions tweak: Lowered the spawn rate of some other mob spawners like tendrils tweak: Added the ability for mob spawners to spawn mobs a distance from their source balance: Cut most ore sources in half and tweaked the spawn weights /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: BogCreature <[email protected]> Co-authored-by: thgvr <[email protected]> Co-authored-by: Mark Suckerberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
In a vain attempt to make mining less boring and actually require more player engagement I have cobbled together the groundwork to a sizable reworking of the mining system from that thing you send out that one random crew member to go do for a couple minutes to a team-based activity focused around the use of specialized equipment.
The gameplay loop for mining I envision within my mind's eye is one where most members of the ship's crew, even down to the engineers and medics, have to cooperate in order to properly secure large amounts of ore from dangerous environments, with most other non-mining ships needing to at least partially rely on mining ships to supply them with minerals.
This PR specifically adds; ore veins (they use the same sprites as geysers pending a better one) that spawn on lava, sand, rock, and ice planets currently and at varying levels of difficulty and yeild, a drill with which to mine said veins, a scanner to find the aforementioned veins, and an outpost mission that is essentially just a mission to go drill ore veins but with money as the reward instead of ore. Oh and I also cut surface mineral spawn rates roughly in half pending a better gauge of the balance involved there.
Here's the harrowing story of one such man who tried to use this drill with no armaments and no crew:
Why It's Good For The Game
Mining in its current state is just kinda bad. It's boring to actually focus on doing and way too easy to just drown your ship in minerals. This PR would at bare minimum partially fix that. That's not to say it's perfect and doesn't need to be balanced and polished to hell and back, but it's a good first step I feel.
Changelog
🆑
add: Ore veins and a drill to mine them with
add: Mining based missions
tweak: Lowered the spawn rate of some other mob spawners like tendrils
tweak: Added the ability for mob spawners to spawn mobs a distance from their source
balance: Cut most ore sources in half and tweaked the spawn weights
/:cl: