Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworks The Visuals Of Independent And Nanotrasen Captains #2453

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

Imaginos16
Copy link
Member

@Imaginos16 Imaginos16 commented Nov 6, 2023

About The Pull Request

Does what it says in the title. This is a demented PR that touches a lot of things, but its main benefit is that now regular independent captains, cowboy independent captains, and nanotrasen captains have a unique identity.

Of those changed, it includes:

  • The Nanotrasen Captain (parade)
    image

  • The Nanotrasen Captain (regular)
    image

  • The Independent Captain (regular/parade)
    image

  • The Independent Captain (western)
    image

The PR also axes a bunch of unused, or frankly quite basic lieutenant outfits that were nothing more than set dressing with not much substance behind them. The roles were not removed for now, and they have appropriate outfits as a placeholder pending a full removal.

This also means that the Head of Personnel was slightly touched up, mostly by having a coat and hat similar to the western captain's when appropriate. The role itself is pending a full visual rework for later that is beyond the scope of this PR.

Speaking of removals, this also means that captain outfits/roles that were there as a legacy of removed ships, were finally axed for good. Goodbye deserter captain for Riggs variant number 4, you will not be missed.

This PR also touches several (a lot) of maps, mostly adding/removing outfits that were either missing, or didn't fit with the dress code of the vessel.

Also the PR fixes an oversight by @MarkSuckerberg by making the BYOND version warning an actual warning, instead of an error when compiling. Etto bleh.

Why It's Good For The Game

Visual cohesion is important, and dear fucking god if I see one more independent western captain not wearing the duster because it wasn't in the ship, I will weep, and my weeping will cause a biblical deluge.

Changelog

🆑 PositiveEntropy
imageadd: Outfits for independent and Nanotrasen captains have been violently reworked.
/:cl:

@Imaginos16 Imaginos16 requested review from a team as code owners November 6, 2023 00:54
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Nov 6, 2023
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once again, wonderful job on this; I really love the nt captain blue a lot!

@thgvr thgvr added this pull request to the merge queue Nov 7, 2023
Merged via the queue into shiptest-ss13:master with commit 40dfaf3 Nov 7, 2023
10 checks passed
@Imaginos16 Imaginos16 deleted the captains-but-not-shit branch November 7, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants