Auxmos update #2483
Merged
Auxmos update #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for additional byond versions tests
## About The Pull Request It is possible to create a callback whose `object` (the datum it tries to call) is a path to an external library. Needless to say, it's probably a bad idea to allow admins to call arbitrary external libraries. Var-edited callbacks won't be able to reach the point where the library is executed, but only because `WrapAdminProcCall` runtimes when trying to call `CanProcCall` on a string, but if there is some way to call a function that creates a non-varedited callback with an external library as its object, this PR prevents that. ## Why It's Good For The Game See above. ## Changelog :cl: admin: Admins are unable to invoke functions from external libraries using callbacks. /:cl:
It is possible to create a callback whose `object` (the datum it tries to call) is a path to an external library. Needless to say, it's probably a bad idea to allow admins to call arbitrary external libraries. Var-edited callbacks won't be able to reach the point where the library is executed, but only because `WrapAdminProcCall` runtimes when trying to call `CanProcCall` on a string, but if there is some way to call a function that creates a non-varedited callback with an external library as its object, this PR prevents that. See above. :cl: admin: Admins are unable to invoke functions from external libraries using callbacks. /:cl:
This is a byond bug, but @san7890 @lessthnthree found it months ago and didn't report it to byond. So I will not open the issue report reporting this byond. They can fucking do that. This pr needs a speed merge because we have linux downstreams that follow upstream code affected by this byond bug. then again skyrat also knows about this bug on top of this workaround and has not opened a bug report so maybe they don't fucking need a speed merge and instead should have filed a bug report with byond. Its out of my hands. --------- Co-authored-by: Watermelon914 <[email protected]>
github-actions
bot
added
the
Map Change
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Mark Suckerberg <[email protected]>
|
well. so. Currently, there's a spurious fail on these ships in the SHIP_PLACEMENT unit test:
I can't troubleshoot it right now, but honestly I just want to get this in, so I'll fix it some other time. We'll just have to deal with it for the time being. Sorry maintainers. |
This reverts commit a4104bc.
|
i'm feeling a bit silly tonight |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shiptest-server
pushed a commit
that referenced
this pull request
Mar 21, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Mar 23, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Updates auxmos to support 515. Support for 514 is being dropped to account for this as the new auxmos version uses the ByondAPI. Closes shiptest-ss13#2489 Lets us use the new features provided in 515, and keep up to date. :cl: server: 515 is required to run shiptest now. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Mark Suckerberg <[email protected]> Co-authored-by: Mothblocks <[email protected]> Co-authored-by: Y0SH1M4S73R <[email protected]> Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: Watermelon914 <[email protected]>
MarkSuckerberg
added a commit
to FalloutFalcon/ShiptestF
that referenced
this pull request
Mar 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Updates auxmos to support 515. Support for 514 is being dropped to account for this as the new auxmos version uses the ByondAPI. Closes shiptest-ss13#2489 ## Why It's Good For The Game Lets us use the new features provided in 515, and keep up to date. ## Changelog :cl: server: 515 is required to run shiptest now. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Mark Suckerberg <[email protected]> Co-authored-by: Mothblocks <[email protected]> Co-authored-by: Y0SH1M4S73R <[email protected]> Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: Watermelon914 <[email protected]>
MarkSuckerberg
pushed a commit
to FalloutFalcon/ShiptestF
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Updates auxmos to support 515. Support for 514 is being dropped to account for this as the new auxmos version uses the ByondAPI.
Closes #2489
Why It's Good For The Game
Lets us use the new features provided in 515, and keep up to date.
Changelog
🆑
server: 515 is required to run shiptest now.
/:cl: