Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further mining changes #2488

Closed
wants to merge 12 commits into from
Closed

Further mining changes #2488

wants to merge 12 commits into from

Conversation

thgvr
Copy link
Member

@thgvr thgvr commented Nov 15, 2023 •
edited
Loading

About The Pull Request

Removes ORM from technology nodes. ORM will still be available for now as loot, or on existing ships.
Stops autolathes from accepting ore, it must be smelted.
This should only be merged AFTER #2446.

Changelog

🆑
del: Ore Redemption Machine is no longer in the "Basic Mining" technology node.
/:cl:

thgvr added 2 commits November 15, 2023 09:21
@thgvr
Edits machine_designs.dm
a2e1a31 
Removes ORM design datum, and removes some extra newlines.
@thgvr
Edits all_nodes.dm
05af36c 
Removes ORM from mining technology node.
@github-actions github-actions bot added the Code change Watch something violently break. label Nov 15, 2023
Erikafox
Erikafox approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do remove it from all ships (for the moment) too.

@thgvr
Edits several files
658f630 
Stops ore from being accepted by autolathes.
@thgvr thgvr changed the title Removes ORM design from the tech tree. Further mining changes Nov 15, 2023
@thgvr thgvr requested a review from a team as a code owner November 15, 2023 20:47
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Nov 15, 2023
MarkSuckerberg
MarkSuckerberg approved these changes Nov 16, 2023
View reviewed changes
code/modules/overmap/objects/outpost/outpost_types.dm Outdated
@@ -84,6 +84,7 @@
elevator_template = /datum/map_template/outpost/elevator_test
// Uses "test" hangars.

/* THGVR TODO: ADD ORE REFINING TO NANOTRASEN ASTEROID OUTPOST, AND REMOVE THIS COMMENT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't believe they still haven't removed this comment in 2027

@thgvr
Copy link
Member Author

thgvr commented Nov 17, 2023

This should ONLY be merged after #2446.

@Xylarr
Copy link

Xylarr commented Nov 17, 2023

my heart is shattered

@A-Medster
Copy link

on one hand, this PR is a really fucking cool idea. having to head to the Outpost for more reasons than buying shit. more reasons to interact with other ships
on the other hand, in practice this really really makes rounds drag,
you now have all these ores, but literally nothing to do with them till you head to the outpost unless you decide to Ghetto Smelt them (AKA tossing it into lava/fire and putting it out afterwards). which tends to hit bigger ships/Ships that land and dont move for a while because they physically cant go to the Outpost, they're trying to get things done. Ruins, RP events, etc.
It also removes most good forms of organizing your minerals outside of the Ore Silo (something that's harder to come by with the Departmental Lathes/Circuit printers) and Crate shelves
i know that ORMs being (sorta) outright gone is a temp thing but my god does it hurt to lack one now. it would be nice if this PR made the more complex version of the Ore Smelting process avalable for printing. like the one on the Outpost where you have to use conveyors to move things from the Box to the Smelter to the Autostacker

@thgvr
Copy link
Member Author

thgvr commented Nov 18, 2023 •
edited
Loading

This won't be merged for some time, and I'll probably go through and set up smelters on ships that deserve it. Need to make all of the machinery not as jank and constructable first, though

@thgvr thgvr marked this pull request as draft November 18, 2023 19:59
@PrefabQuasar PrefabQuasar mentioned this pull request Nov 19, 2023
Open
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@thgvr
Merge branch 'master'
8606ab2 
Conflicts:
	code/modules/research/designs/machine_designs.dm
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 22, 2023
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@thgvr
Merge branch 'master'
0971e68 
Conflicts:
	code/modules/research/techweb/all_nodes.dm
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Dec 13, 2023
@Sweettoothart Sweettoothart mentioned this pull request Jan 25, 2024
Closed
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Feb 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@thgvr
Copy link
Member Author

thgvr commented Mar 12, 2024

I'll think about this again after I can improve the smelter machines further.

@thgvr thgvr closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erikafox Erikafox Erikafox approved these changes

@MarkSuckerberg MarkSuckerberg Awaiting requested review from MarkSuckerberg

Assignees
No one assigned
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Merge Conflict Use Git Hooks, you're welcome.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thgvr @Xylarr @A-Medster @MarkSuckerberg @Erikafox