Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather Radio Port #2517

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Conversation

GenericDM
Copy link
Member

@GenericDM GenericDM commented Nov 23, 2023

About The Pull Request

Port of tgstation/tgstation#76961, which is itself a port of lizardqueenlexi/orbstation#630.
This PR will add one new object, the portable weather radio.
theradio
image
image
Wallmount shown in these has been axed.

Todo

  • Fix the existing code to work for our cases.
  • Fix runtime errors.
  • Stay hydrated.

Why It's Good For The Game

They look neat, they add flavor, and the barometer function on analyzers is used maybe once every 50 rounds.

Changelog

🆑 CoiledLamb, Jacquerel, GenericDM
add: Adds Weather Radios!
/🆑

@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Nov 23, 2023
a location that does not have weather
@Admiral-Gigaton
Copy link

Is good, hope for merge

@GenericDM GenericDM marked this pull request as ready for review November 28, 2023 23:52
@GenericDM GenericDM requested a review from a team as a code owner November 28, 2023 23:52
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Dec 6, 2023
Merged via the queue into shiptest-ss13:master with commit 6b60388 Dec 6, 2023
10 checks passed
@GenericDM GenericDM deleted the weatherRadio branch December 10, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants