Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RILENA MERCH #2531

Merged
merged 21 commits into from
Dec 4, 2023
Merged

RILENA MERCH #2531

merged 21 commits into from
Dec 4, 2023

Conversation

MoonTheBird
Copy link
Contributor

@MoonTheBird MoonTheBird commented Nov 27, 2023

About The Pull Request

Adds merch from everyone's favorite combination webcomic and video game, RILENA: LMR.
PLUSHIES
image
OUTFITS
image
POSTERS
image
DRINKS (and mug)
image
OTHER STUFF
image

Why It's Good For The Game

The game needs this. I promise.

Changelog

🆑
add: Added a LOT of RILENA merch. Plushies, drinks, hoodies, shirts, cosplays... And if you're a RILENA fan (positive trait), you get a special pin, like the clown or mime fan!
/:cl:

@MoonTheBird MoonTheBird requested a review from a team as a code owner November 27, 2023 04:53
@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Nov 27, 2023
@Zevotech
Copy link
Contributor

put pictures of your sprites in the pr homeslice

@MoonTheBird
Copy link
Contributor Author

put pictures of your sprites in the pr homeslice

forgor 💀 anyway I was about to go to sleep but I'll do that

Copy link
Member

@thgvr thgvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things

code/game/objects/items/plushes.dm Outdated Show resolved Hide resolved
code/game/objects/items/plushes.dm Outdated Show resolved Hide resolved
code/modules/clothing/suits/hoodies.dm Outdated Show resolved Hide resolved
code/modules/clothing/suits/hoodies.dm Outdated Show resolved Hide resolved
Signed-off-by: Moon <[email protected]>
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Nov 28, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 28, 2023
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little bit of feedback

code/datums/traits/good.dm Outdated Show resolved Hide resolved
code/game/objects/effects/contraband.dm Outdated Show resolved Hide resolved
code/game/objects/effects/contraband.dm Show resolved Hide resolved
code/modules/clothing/suits/hoodies.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the DME Edit label Nov 28, 2023
@MoonTheBird
Copy link
Contributor Author

gimme a sec I'm fixing stuff

@MoonTheBird
Copy link
Contributor Author

I fixed stuff

@meemofcourse
Copy link
Contributor

I'm stuff

/obj/item/toy/plush/rilena
name = "RILENA:LMR Ri plushie"
desc = "A plush of the protagonist of the popular combination video game series and webcomic RILENA."// Makes the iconic hurt sound from the game!" //sadly does not :pensive:
icon_state = "rilena_ri"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
icon_state = "rilena_ri"
icon_state = "rilenaplush_ri"

/obj/item/toy/plush/tali
name = "RILENA:LMR T4L1 plushie"
desc = "A surprisingly soft plushie of a recurring miniboss from the popular combination video game series and webcomic RILENA. The cannon arm does not function."
icon_state = "rilena_t4l1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
icon_state = "rilena_t4l1"
icon_state = "rilenaplush_t4l1"

/obj/item/toy/plush/sharai
name = "RILENA:LMR Sharai plushie"
desc = "A plushie of the four winged kepori boss from the popular combination video game series and webcomic RILENA."
icon_state = "rilena_sharai"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
icon_state = "rilena_sharai"
icon_state = "rilenaplush_sharai"

/obj/item/toy/plush/xader
name = "RILENA:LMR Xader plushie"
desc = "A plushie of the recurring transdimensional transgender shopkeep from the popular webseries RILENA."
icon_state = "rilena_xader"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
icon_state = "rilena_xader"
icon_state = "rilenaplush_xader"

/obj/item/toy/plush/mora
name = "RILENA:LMR Mora plushie"
desc = "A plushie of Mora from the popular webseries RILENA."
icon_state = "rilena_mora"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
icon_state = "rilena_mora"
icon_state = "rilenaplush_mora"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be stupid

@MoonTheBird
Copy link
Contributor Author

hopefully this fixes my mistakes

@Nikitaw99
Copy link

The mood buff RILENA fans get from having a hoodie on and having some merch on them stack up together which could make mood management a little too easy (that said I run hypersensitive anyway); Maybe you could tweak them so they have the same non-stacking buff or something?

@MoonTheBird
Copy link
Contributor Author

That seems fair.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 3, 2023
Copy link
Contributor

github-actions bot commented Dec 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Dec 3, 2023
@MoonTheBird
Copy link
Contributor Author

okay I think this is good now

@thgvr thgvr added this pull request to the merge queue Dec 4, 2023
Merged via the queue into shiptest-ss13:master with commit 3d16ce9 Dec 4, 2023
10 checks passed
MysticalFaceLesS added a commit to CeladonSS13/Shiptest that referenced this pull request Dec 4, 2023
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Dec 6, 2023
## About The Pull Request
Adds merch from everyone's favorite combination webcomic and video game,
RILENA: LMR.
PLUSHIES

![image](https://github.com/shiptest-ss13/Shiptest/assets/64121399/c17df0a0-823f-432a-b29b-7a78b8a9594b)
OUTFITS

![image](https://github.com/shiptest-ss13/Shiptest/assets/64121399/821a3adc-edab-4db4-bfed-0a179547de94)
POSTERS

![image](https://github.com/shiptest-ss13/Shiptest/assets/64121399/7606c0e9-5cf0-4069-8f1f-92e9663ee8f8)
DRINKS (and mug)

![image](https://github.com/shiptest-ss13/Shiptest/assets/64121399/868373c3-98d9-4fee-b727-ef3c196a837d)
OTHER STUFF

![image](https://github.com/shiptest-ss13/Shiptest/assets/64121399/0beef48d-532e-48d0-9777-8c5585a03c53)

## Why It's Good For The Game
The game needs this. I promise.
## Changelog
:cl:
add: Added a LOT of RILENA merch. Plushies, drinks, hoodies, shirts,
cosplays... And if you're a RILENA fan (positive trait), you get a
special pin, like the clown or mime fan!
/:cl:

---------

Signed-off-by: Moon <[email protected]>
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants