fixes some backend shipjoin stuff #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i believe so; the chain is something like attemptlatejoin -> isjobeligible (or isjobavailable? or something?) -> has_job_playtime. dunno if those are the exact names since i can't search the codebase easily right now really, i should probably move the relevant calculations into ui_static_data() and just send them to the UI so that it's all centralized. but |
|
turns out that shipowners can infinitely open slots on their ships, because joining a ship decrements the slot counter. this is bad. need to fix it |
MarkSuckerberg
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
admin + DB flag exemptions weren't respected by the ship joining UI, but all players were assumed to have the requisite playtime to spawn / join a ship by the code that actually handled joining. this fixes both, technically fixing an href exploit i suppose
Why It's Good For The Game
bugs bad + consistency good. i am bad at web dev
Changelog
🆑
fix: Small playtime-based ship join restriction edge cases fixed.
/:cl: