Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legion corpse rework #2543

Merged
merged 90 commits into from
May 31, 2024
Merged

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Nov 29, 2023

About The Pull Request

Kills off a lot of the bad corpses that just didn't make much sense IC
Also making them feel a little more real by sub typing them under a generic outfit which pulls clothing from load outs.
Also tweaks a lot of the existing spawns to make them a little more balanced
This will replace a lot of the removed outfits with independent jobs

corpses
image
image
image

Why It's Good For The Game

The balance of the legion loot felt a little off and had to much gear that messed up faction identity
This does however improve the variety and randomness to the point you cant look at a corpse and know its not a real player.
While the loot is a lot less powerful there will be a lot more variety i hope

Changelog

🆑

add: Added new more varied legion corpses
del: Removed lot of the crappy legion corpses
balance: rebalanced most of the old legion corpses
refactor: moved most legion corpse loot behavior to outfits
/:cl:

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Mar 27, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Apr 1, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Apr 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Apr 16, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Apr 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Apr 23, 2024
@FalloutFalcon FalloutFalcon added Test Merged They've done it for free. and removed Test Merge Candidate You do it for free. labels May 28, 2024
@Sun-Soaked Sun-Soaked self-requested a review May 31, 2024 02:42
Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we'll have to come back to that unit test though

@Sun-Soaked Sun-Soaked added this pull request to the merge queue May 31, 2024
Merged via the queue into shiptest-ss13:master with commit 149dcfb May 31, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jun 1, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Kills off a lot of the bad corpses that just didn't make much sense IC
Also making them feel a little more real by sub typing them under a
generic outfit which pulls clothing from load outs.
Also tweaks a lot of the existing spawns to make them a little more
balanced
This will replace a lot of the removed outfits with independent jobs


![corpses](https://github.com/shiptest-ss13/Shiptest/assets/86381784/9aa8b114-afff-4616-8021-db1553c6fc01)

![image](https://github.com/shiptest-ss13/Shiptest/assets/86381784/3f44fcca-f38b-4d64-bb7d-c1be33479c2d)

![image](https://github.com/shiptest-ss13/Shiptest/assets/86381784/4eb44536-81d1-45ec-9eb1-34499ba475ef)

![image](https://github.com/shiptest-ss13/Shiptest/assets/86381784/d75870ac-d0a5-496e-a826-88158623e665)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

The balance of the legion loot felt a little off and had to much gear
that messed up faction identity
This does however improve the variety and randomness to the point you
cant look at a corpse and know its not a real player.
While the loot is a lot less powerful there will be a lot more variety i
hope

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:

add: Added  new more varied legion corpses
del: Removed lot of the crappy legion corpses
balance: rebalanced most of the old legion corpses
refactor: moved most legion corpse loot behavior to outfits
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: Mark Suckerberg <[email protected]>
Co-authored-by: Sun-Soaked <[email protected]>
Yobrocharlie added a commit to Yobrocharlie/Shiptest that referenced this pull request Jul 23, 2024
@FalloutFalcon FalloutFalcon deleted the legion-rework branch January 7, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Test Merged They've done it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants