Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes spacegym.dmm #2544

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

Zevotech
Copy link
Contributor

About The Pull Request

Removes spacegym.dmm and its associated code and map catalogue entry.
Also removes the spacegym lootdrops from the colossus. (Please do not add weirdly named lootdrops to your map without checking their contents, this had hulk injectors in it.)

Why It's Good For The Game

2023-11-29 17 15 20
you look at this and tell me theres a god.

Changelog

🆑
del: spacegym.dmm and associated code removed
del: removed spacegym lootdrops from the colossus
/:cl:

@Zevotech Zevotech requested a review from a team as a code owner November 29, 2023 22:30
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Nov 29, 2023
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Dec 1, 2023
Merged via the queue into shiptest-ss13:master with commit 34bf15f Dec 1, 2023
10 checks passed
MysticalFaceLesS added a commit to CeladonSS13/Shiptest that referenced this pull request Dec 4, 2023
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Dec 6, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Removes spacegym.dmm and its associated code and map catalogue entry.
Also removes the spacegym lootdrops from the colossus. (Please do not
add weirdly named lootdrops to your map without checking their contents,
this had hulk injectors in it.)
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
![2023-11-29 17 15
20](https://github.com/shiptest-ss13/Shiptest/assets/95449138/040bb751-1a81-4b65-8aa6-877aa616ba41)
you look at this and tell me theres a god. 
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
del: spacegym.dmm and associated code removed
del: removed spacegym lootdrops from the colossus
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants