Reworks the turbine to be an actual engine #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DME Edit
Sprites
github-actions
bot
added
the
Map Change
ToasterBiome
approved these changes
Dec 13, 2023
|
I'm rubbing my dirty little mapper paws together criminally at the thought of mapping with this thing |
rye-rice
approved these changes
Dec 24, 2023
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Turbine with a real sprite is cursed as all hell and I love it. |
MarkSuckerberg
approved these changes
Jan 22, 2024
west3436
reviewed
Feb 4, 2024
west3436
reviewed
Feb 4, 2024
|
@tmtmtl30 review? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Closed
|
I didn't notice this failed to merge so LGTM |
shiptest-server
pushed a commit
that referenced
this pull request
Apr 11, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Apr 12, 2024
## About The Pull Request This PR allows the turbine to provide thrust like a real engine while it's running (equivalent to around 4 plasma thrusters while running at maximum power) and fixes a few things like being able to make power from nothing and disconnecting when docking or undocking. Also updates the sprites to make it nicer to look at.  Sprites are from BeeStation/BeeStation-Hornet#7634, by PestoVerde322 and PacifistDalek ## Why It's Good For The Game For how much worse and less efficient the turbine is at power generation compared to the TEG, I thought it deserved a secondary use to make it more interesting. This also allows for the possibility of a new ship that uses one (or more!) as its main engine, which would be cool. Also turbines violating the laws of thermodynamics to make power from nowhere is maybe bad or something. ## Changelog :cl: sapphicoverload, PestoVerde322, PacifistDalek add: turbines now provide thrust for ships tweak: turbines respect conservation of energy instead of moving gas around for free tweak: turbine control console now shows the internal pressure of the turbine code: refactored how gas flows through the turbine fix: fixed turbines making free energy from nowhere at low RPM fix: fixed turbines forcing air into the output turf when it's blocked fix: fixed turbines not updating air at the input and output turfs fix: fixed turbines disconnecting when docking and undocking imageadd: new turbine sprites /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Apr 15, 2024
## About The Pull Request This PR allows the turbine to provide thrust like a real engine while it's running (equivalent to around 4 plasma thrusters while running at maximum power) and fixes a few things like being able to make power from nothing and disconnecting when docking or undocking. Also updates the sprites to make it nicer to look at.  Sprites are from BeeStation/BeeStation-Hornet#7634, by PestoVerde322 and PacifistDalek ## Why It's Good For The Game For how much worse and less efficient the turbine is at power generation compared to the TEG, I thought it deserved a secondary use to make it more interesting. This also allows for the possibility of a new ship that uses one (or more!) as its main engine, which would be cool. Also turbines violating the laws of thermodynamics to make power from nowhere is maybe bad or something. ## Changelog :cl: sapphicoverload, PestoVerde322, PacifistDalek add: turbines now provide thrust for ships tweak: turbines respect conservation of energy instead of moving gas around for free tweak: turbine control console now shows the internal pressure of the turbine code: refactored how gas flows through the turbine fix: fixed turbines making free energy from nowhere at low RPM fix: fixed turbines forcing air into the output turf when it's blocked fix: fixed turbines not updating air at the input and output turfs fix: fixed turbines disconnecting when docking and undocking imageadd: new turbine sprites /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR allows the turbine to provide thrust like a real engine while it's running (equivalent to around 4 plasma thrusters while running at maximum power) and fixes a few things like being able to make power from nothing and disconnecting when docking or undocking.
Also updates the sprites to make it nicer to look at.
Sprites are from BeeStation/BeeStation-Hornet#7634, by PestoVerde322 and PacifistDalek
Why It's Good For The Game
For how much worse and less efficient the turbine is at power generation compared to the TEG, I thought it deserved a secondary use to make it more interesting. This also allows for the possibility of a new ship that uses one (or more!) as its main engine, which would be cool.
Also turbines violating the laws of thermodynamics to make power from nowhere is maybe bad or something.
Changelog
🆑 sapphicoverload, PestoVerde322, PacifistDalek
add: turbines now provide thrust for ships
tweak: turbines respect conservation of energy instead of moving gas around for free
tweak: turbine control console now shows the internal pressure of the turbine
code: refactored how gas flows through the turbine
fix: fixed turbines making free energy from nowhere at low RPM
fix: fixed turbines forcing air into the output turf when it's blocked
fix: fixed turbines not updating air at the input and output turfs
fix: fixed turbines disconnecting when docking and undocking
imageadd: new turbine sprites
/:cl: