Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"fixes" material tiles #2603

Merged
merged 1 commit into from
Dec 20, 2023
Merged

"fixes" material tiles #2603

merged 1 commit into from
Dec 20, 2023

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Dec 19, 2023

About The Pull Request

No longer will you have to see a massive fix me when you accidentally create material tiles instead of the ones you actually wanted!

Fixes #2528
image

Why It's Good For The Game

I would argue for scraping them entirely but that fix me sprite was REALLY annoying me, We have had it for 2 years based on the commit history

Changelog

🆑
fix: Material tile sprites
/:cl:

@FalloutFalcon FalloutFalcon requested a review from a team as a code owner December 19, 2023 04:37
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Dec 19, 2023
@thgvr
Copy link
Member

thgvr commented Dec 19, 2023

It's fine if you don't want to, but it would be better to just remove these as they are often confusing when making normal floor tiles and the sprites aren't being maintained.

@FalloutFalcon
Copy link
Member Author

It's fine if you don't want to, but it would be better to just remove these as they are often confusing when making normal floor tiles and the sprites aren't being maintained.

To be fair it is sprite, singular, currently but i do agree that material tiles are gross and only ever created by accident. I will put fully removing them somewhere in my list of things to do but I will do it in a separate pr if i do

@thgvr
Copy link
Member

thgvr commented Dec 20, 2023

That's fine.

@thgvr thgvr added this pull request to the merge queue Dec 20, 2023
Merged via the queue into shiptest-ss13:master with commit 5e51e05 Dec 20, 2023
14 checks passed
MysticalFaceLesS added a commit to CeladonSS13/Shiptest that referenced this pull request Dec 21, 2023
@FalloutFalcon FalloutFalcon deleted the tiles branch March 5, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Material tiles are broken
2 participants