Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the decompressed katana bricking itself #2608

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

SomeguyManperson
Copy link
Contributor

@SomeguyManperson SomeguyManperson commented Dec 21, 2023

About The Pull Request

code pulled the blade out of the sheath before checking if it was viably targetted meaning you could remove the blade without clearing the lock on the sheath

Why It's Good For The Game

fixes #2501

Changelog

🆑
fix: the weebstick is no longer held back from its true purpose if you click on a tile you can't see
/:cl:

Signed-off-by: Theos <[email protected]>
@github-actions github-actions bot added the Code change Watch something violently break. label Dec 21, 2023
@SomeguyManperson SomeguyManperson changed the title fix 2501 Fixes the metal gear katana bricking itself Dec 21, 2023
Copy link
Member

@thgvr thgvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@thgvr
Copy link
Member

thgvr commented Dec 21, 2023

(also it's a reference to Decompressed )

@SomeguyManperson SomeguyManperson changed the title Fixes the metal gear katana bricking itself Fixes thedecompressed katana bricking itself Dec 21, 2023
@SomeguyManperson SomeguyManperson changed the title Fixes thedecompressed katana bricking itself Fixes the decompressed katana bricking itself Dec 21, 2023
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Dec 28, 2023
Merged via the queue into shiptest-ss13:master with commit 8ca8fd2 Dec 28, 2023
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Dec 30, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

code pulled the blade out of the sheath before checking if it was viably
targetted meaning you could remove the blade without clearing the lock
on the sheath

## Why It's Good For The Game

fixes shiptest-ss13#2501

## Changelog

:cl:
fix: the weebstick is no longer held back from its true purpose if you
click on a tile you can't see
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Signed-off-by: Theos <[email protected]>
@SomeguyManperson SomeguyManperson deleted the patch-4 branch January 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with ogre blade/sheath
3 participants