Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunter's Pride #2618

Merged
merged 34 commits into from
Feb 5, 2024
Merged

Hunter's Pride #2618

merged 34 commits into from
Feb 5, 2024

Conversation

rye-rice
Copy link
Member

@rye-rice rye-rice commented Jan 2, 2024

About The Pull Request

image

Resprites the entirety of the Hunter's Pride gun manufacturer and adds some extra weapons, specifically for the SRM.

As Hunter's Pride's lineup also intersects with the SRM weapon lineup, this was very interesting to do. However, thanks to the SRM lorema and lorehead in general Valorium for helping clear things up, and as usual Apogee-dev for any gun-related work I do. Without them this would have been much harder and much lower quality than how it came out. In fact, Apogee went above and beyond and designed two entirely original guns for this, the Firestorm and Vickland!

"An unconventional submachinegun, rarely issued to Saint-Roumain Militia mercenary hunters for outstanding situations where normal hunting weapons fall short. Chambered in .45."
image

"The pride of the Saint-Roumain Militia, the Vickland is a rare semi-automatic battle rifle produced by Hunter's Pride exclusively for SRM use. It is unusual in its class for its internal rotary magazine, which must be reloaded using stripper clips. Chambered in .308."
image

Special thanks to FleetingExpertise for drawing the Ammo box!

Double barreled shotguns and the Beacon (formerly the contender), also now work like actual break actions! Use the Unique Action key to break them open, load them up, then hit it again to close them.

Many other weapons are given sawn off options as the new gun recoil/twohanded mechanics means theres a better tradeoff to sawing them off rather than haha weapon in bag

Also, disposable guns are now 22lr with 10 round magazines. They're still horrible, just somewhat less so.

There's various smaller changes in the changelog I probably didn't mention here, go take a look at them.

Requires #2599

Why It's Good For The Game

image

Changelog

🆑 retlaw34, FleetingExpertise, Apogee-dev, Valorium,
add: Resprites almost every single hunter's pride weapon
add: Added the Vickland, SRM equivlent to the ARs except it's an battle rifle
add: The Illestren is now an en-bloc rifle and uses 8x50mmR. Functionally it's the exact same to aquire the ammo, just with a different name
add: You are able to saw off many more guns than before, just be sure to actually empty it before doing so!
add: Many Hunter's pride weapons have been renamed to something befitting the lore
add: Break action weapons
fix: Traubuco should work correctly again
fix: Some broken gun onmobs should now show up
tweak: guns tell you how to rack them or switching firing modes
balance: smgs fire 0.02 seconds faster and now have standard pistol recoil onehanded
balance: disposable guns are now less shit, they now have 10 rounds! The downside is they are now chambered in 22lr, the worst caliber in the game
balance: Shotguns have been nerfed to not do an insane amount of damage point blank and in general

/:cl:

@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Sound USSR Anthem 2.66 MB file. Code change Watch something violently break. labels Jan 2, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jan 10, 2024
@rye-rice rye-rice marked this pull request as ready for review January 10, 2024 05:50
@rye-rice rye-rice requested review from a team as code owners January 10, 2024 05:50
@rye-rice rye-rice requested a review from Apogee-dev January 10, 2024 05:51
@rye-rice
Copy link
Member Author

Undrafted and ready for review. Unrelated, it feels nice to go back and redo old sprites i did years ago, and it looking much better now.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jan 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jan 18, 2024
Copy link
Member

@Imaginos16 Imaginos16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha cat's out of the bag I'm back baybee

@thgvr
Copy link
Member

thgvr commented Feb 4, 2024

All good?

@thgvr thgvr added this pull request to the merge queue Feb 5, 2024
Merged via the queue into shiptest-ss13:master with commit 0e67fc4 Feb 5, 2024
15 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Feb 7, 2024
![image](https://github.com/shiptest-ss13/Shiptest/assets/58402542/c44b78d1-a455-46fc-95d2-20562eed7d9e)

Resprites the entirety of the Hunter's Pride gun manufacturer and adds
some extra weapons, specifically for the SRM.

As Hunter's Pride's lineup also intersects with the SRM weapon lineup,
this was very interesting to do. However, thanks to the SRM lorema and
lorehead in general Valorium for helping clear things up, and as usual
Apogee-dev for any gun-related work I do. Without them this would have
been much harder and much lower quality than how it came out. In fact,
Apogee went above and beyond and designed two entirely original guns for
this, the Firestorm and Vickland!

*"An unconventional submachinegun, rarely issued to Saint-Roumain
Militia mercenary hunters for outstanding situations where normal
hunting weapons fall short. Chambered in .45."*

![image](https://github.com/shiptest-ss13/Shiptest/assets/58402542/5864d6fc-fb79-4329-a695-79e5360e0a08)

*"The pride of the Saint-Roumain Militia, the Vickland is a rare
semi-automatic battle rifle produced by Hunter's Pride exclusively for
SRM use. It is unusual in its class for its internal rotary magazine,
which must be reloaded using stripper clips. Chambered in .308."*

![image](https://github.com/shiptest-ss13/Shiptest/assets/58402542/86625ed8-7295-4418-815d-7f1eb8bc7150)

Special thanks to FleetingExpertise for drawing the Ammo box!

Double barreled shotguns and the Beacon (formerly the contender), also
now work like actual break actions! Use the Unique Action key to break
them open, load them up, then hit it again to close them.

Many other weapons are given sawn off options as the new gun
recoil/twohanded mechanics means theres a better tradeoff to sawing them
off rather than haha weapon in bag

Also, disposable guns are now 22lr with 10 round magazines. They're
still horrible, just somewhat less so.

There's various smaller changes in the changelog I probably didn't
mention here, go take a look at them.

Requires shiptest-ss13#2599

![image](https://github.com/shiptest-ss13/Shiptest/assets/58402542/8285d29f-36e2-43e4-bc2b-4327b18a9570)

:cl: retlaw34, FleetingExpertise, Apogee-dev, Valorium,
add: Resprites almost every single hunter's pride weapon
add: Added the Vickland, SRM equivlent to the ARs except it's an battle
rifle
add: The Illestren is now an en-bloc rifle and uses 8x50mmR.
Functionally it's the exact same to aquire the ammo, just with a
different name
add: You are able to saw off many more guns than before, just be sure to
actually empty it before doing so!
add: Many Hunter's pride weapons have been renamed to something
befitting the lore
add: Break action weapons
fix: Traubuco should work correctly again
fix: Some broken gun onmobs should now show up
tweak: guns tell you how to rack them or switching firing modes
balance: smgs fire 0.02 seconds faster and now have standard pistol
recoil onehanded
balance: disposable guns are now less shit, they now have 10 rounds! The
downside is they are now chambered in 22lr, the worst caliber in the
game
balance: Shotguns have been nerfed to not do an insane amount of damage
point blank and in general

/:cl:
@lectronyx
Copy link

Aw, the Nagant replacement can't be silenced :(

@rye-rice
Copy link
Member Author

rye-rice commented Apr 2, 2024

What nagant replacement? I don't ever remember replacing the nagant, just killed it upright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sound USSR Anthem 2.66 MB file. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants