Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resprites medical and utility belts #2638

Merged
merged 7 commits into from
Feb 10, 2024
Merged

Conversation

BarteG44
Copy link

@BarteG44 BarteG44 commented Jan 10, 2024

About The Pull Request

Aims to displace the very soulful sprites with slightly less soulful sprites. I did my best with these but if everything goes according to plan, some better spriter will find these so awful that they'll make better ones out of spite

image
298284453-5857e3b8-a207-4516-a395-4df766ac0491
image

Why It's Good For The Game

man...
image

Changelog

🆑
tweak: resprited the medical and utility belts
/:cl:

@BarteG44 BarteG44 requested a review from a team as a code owner January 10, 2024 19:21
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Jan 10, 2024
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

augugha, sorry for not getting to this sooner

the onmobs are okay, just kill the 'old' sprites

image

the obj state has a ton of banding on the back of the belt,

x1SVec4-2156615795

if you removed the staircasing it would make it a lot better and probably would be mergable then. Once again, i'm sorry for taking forever to get to this

@BarteG44
Copy link
Author

something like this?
image

image

@rye-rice
Copy link
Member

Yeah, something like that.

Make the the parts that are closer to the camera lighter, and the parts furthest darker

@BarteG44
Copy link
Author

Make the the parts that are closer to the camera lighter, and the parts furthest darker

shouldn't the surfaces facing away from the camera be the darkest tho

@thgvr
Copy link
Member

thgvr commented Feb 4, 2024

Please go ahead with the requested changes

@BarteG44
Copy link
Author

BarteG44 commented Feb 5, 2024

I would if i knew what the request meant cause surely it doesn't mean something like this
Screenshot_20240205-083454_Pixel Studio

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@BarteG44
Copy link
Author

BarteG44 commented Feb 7, 2024

github is hard

@BarteG44 BarteG44 reopened this Feb 7, 2024
@github-actions github-actions bot added DME Edit and removed Merge Conflict Use Git Hooks, you're welcome. labels Feb 7, 2024
@BarteG44
Copy link
Author

BarteG44 commented Feb 7, 2024

fuckin dme what

@goober3
Copy link
Member

goober3 commented Feb 7, 2024

fuckin dme what

i recommend taking whatever sprites you added / modified in this PR and transferring it to a different branch that's been updated from master. dme conflicts are a pain.

This reverts commit 712adfc.
@github-actions github-actions bot removed the DME Edit label Feb 7, 2024
@BarteG44
Copy link
Author

BarteG44 commented Feb 7, 2024

we'll see

BarteG44 added 2 commits February 8, 2024 00:48
how many commits does it take to change a light bulb
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its alright

@thgvr thgvr added this pull request to the merge queue Feb 9, 2024
Merged via the queue into shiptest-ss13:master with commit 84487af Feb 10, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Feb 11, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Aims to displace the very soulful sprites with slightly less soulful
sprites. I did my best with these but if everything goes according to
plan, some better spriter will find these so awful that they'll make
better ones out of spite
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

![image](https://github.com/shiptest-ss13/Shiptest/assets/105491762/42c94833-132a-4391-9886-815104191884)

![298284453-5857e3b8-a207-4516-a395-4df766ac0491](https://github.com/shiptest-ss13/Shiptest/assets/105491762/ea50fa73-1818-4e69-9ac6-5472f5959dff)

![image](https://github.com/shiptest-ss13/Shiptest/assets/105491762/5b05b1c8-ff6c-4977-8b43-5751e815e035)


## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->
man...

![image](https://github.com/shiptest-ss13/Shiptest/assets/105491762/78e9bfce-b265-4c8a-8d52-81a68a515eb1)


## Changelog

:cl:
tweak: resprited the medical and utility belts
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants