-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a lava canyon as a new lava planet ruin #2642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, a lavaland ruin! Finally!
Starting off strong, you did an excellent job blending the area of the ruin with the natural environment. The fact that I can't see where the planetgen ends and the ruin begins is a huge win for this ruin. This is a positive comment, no need to change anything about the ruin in terms of environment as far as I can tell.
This may surprise you, but the BDM is actually passive and minds their business until you attack them! People can just walk up and yoink that chest with no risk. I'd either remove the chest, or put it behind a locked gate with a setup similar to the ashdrake ruin (Boss drops a key to the gate) to prevent people from just snatching it. Remember that the boss itself is a pretty big reward for anyone competent enough to beat it.
Two things. One, the ashwalker corpses will get husked by the first storm that comes in which may mess with the vibes you were going for. Second, mixing these two types of walls is weird. I'd either stick with just using sandstone or necropolis walls to really send the ashie vibes home.
Interesting setup here. I'm not sure if this is a reference to something so I'm going to suggest changing the dusty shard to something more rewarding or removing it altogether and replacing it with a shield or something.
This is silly and great. I had no idea these tiles dropped out and rose back up like a platformer game. No change requested here.
The scrap metal/titanium feels out of place in this ruin, I'd just replace it with ore. Also having bone weapons everywhere on the floor feels weird. Maybe have them in a dedicated armory hut or just on/next to corpses.
Anyways this is a pretty great ruin. Hope to see it merged quickly because its in a pretty good state as-is.
Tming this gonna test it live =) |
I want to test this in game one more time. But otherwise I think this is rad as fuck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely beautiful map. Swap out the narsien armor in the chest for something else and we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful map
## About The Pull Request Adds a lava canyon ruin, with the remains of a scorched ashwalker village nestled between the crags. Comes with an associated area for this ruin. ![2024-01-29 16 50 44](https://github.com/shiptest-ss13/Shiptest/assets/116136632/efe9ab52-7908-4b6f-b966-cdcae7d9d470) ![2024-01-29 16 50 41](https://github.com/shiptest-ss13/Shiptest/assets/116136632/36831083-e337-470b-8fb9-35de5d8b84cd) A blood drunk miner defending a vault of loot! ![Screenshot 2024-01-29 165828](https://github.com/shiptest-ss13/Shiptest/assets/116136632/63214e38-316f-4dd4-a120-b418c123b7a5) ## Why It's Good For The Game Lava planets need ruins. ## Changelog :cl: add: New lava canyon ruin fix: Gate icon updates not working /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
About The Pull Request
Adds a lava canyon ruin, with the remains of a scorched ashwalker village nestled between the crags. Comes with an associated area for this ruin.
A blood drunk miner defending a vault of loot!
Why It's Good For The Game
Lava planets need ruins.
Changelog
🆑
add: New lava canyon ruin
fix: Gate icon updates not working
/:cl: