Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pAI Tweaks, Holochassis, & Radials #2643

Merged

Conversation

Skies-Of-Blue
Copy link
Contributor

@Skies-Of-Blue Skies-Of-Blue commented Jan 15, 2024

About The Pull Request

Various ports, per request:
BeeStation/BeeStation-Hornet#4917 Crow holochassis! (mycophobes stay winning)
BeeStation/BeeStation-Hornet#4944 Puppy holochassis!
BeeStation/BeeStation-Hornet#5601 A smattering of holochassis (no Bee or Ghost)! + inhands for all holochassis. Rejoice!
tgstation/tgstation#52879 Radials for holochassis selection!
BeeStation/BeeStation-Hornet#8269 Radials for screen selection!
BeeStation/BeeStation-Hornet#8977 and a final mothroach holochassis, for good luck.

Credit to Crushtoe, MistakeNot4892, and Pirill for the spritework!

Why It's Good For The Game

These poor pAI players have been feeding on scraps for so long. Did you know that less than half of our available holochassis were capable of being held by players? No longer! Also swaps screen+chassis selection over from lists to radials, because having a preview of what you're selecting is nice, and it's 2024.

Here are the radials in action, as well as a teaser for a few of the new holochassis:
pAI Mains Eating Good Tonight

<|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|>

Changelog

🆑
imageadd: several new pAI holochassis
imageadd: held sprites for every existing pAI holochassis
tweak: all pAI holochassis can now be held
tweak: pAI screen and holochassis selections are now radials instead of lists
spellcheck: several instances of code are now feeling less michevious
🆑

@Skies-Of-Blue Skies-Of-Blue requested a review from a team as a code owner January 15, 2024 08:09
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Jan 15, 2024
@thgvr
Copy link
Member

thgvr commented Jan 15, 2024

pls no goon bee

Spider's kind of meh too, it's huge and got weird colors. Same for mushroom

@Skies-Of-Blue
Copy link
Contributor Author

The bee here is explicitly not from goon, in fact. That was mentioned in the original PR. I can remove it if needed, however!

@thgvr
Copy link
Member

thgvr commented Jan 15, 2024

After going through the sprites I'd say to axe spider, walking mushroom, the bee(i know what the pr said but it looks exactly like goon) and the destiny one

@Sweettoothart
Copy link

Sweettoothart commented Jan 15, 2024

The spider one is really good though?? PAI's need more options and spider is a really good one. Its green and black too?

@thgvr
Copy link
Member

thgvr commented Jan 15, 2024

image
Here it's zoomed in for reference. It's the tg spider sprite with a thick dark blue outline and some colors swapped. It's also too large imo

@Skies-Of-Blue
Copy link
Contributor Author

Skies-Of-Blue commented Jan 15, 2024

Full admission, the ghost wasn't axed purely out of laziness. I'll definitely be sure to remove that, the mushroom, and the Not!Goon Bee. No big losses there.

The spider, however, is a darling of mine. Size-wise it's quite similar to the hawk or the fox, only marginally larger. When playing as a pAI, it's great to have a visual Notice Me! option, and the spider's color/size combo fill that niche well. It's far from our ugliest sprite, too; the fox chassis is both massive and crusty. I would prefer to keep the spider in its current state, if at all possible.

I'll address any necessary changes tomorrow.

edit: comment was written before I noticed thgvr's response. oops.

@thgvr
Copy link
Member

thgvr commented Jan 15, 2024

Spider needs to have a smaller design and more in line colors with the rest of them. The fox sucks, but it's old so whatever. I know hawk is quite big but it's not a recolored enemy sprite. Also, the snake's movement state's first icons for n/s are raised up too high, so it looks like its jumping.

PAIs could really use some sprite love honestly, but that's certainly not a job i'll push onto someone. I'm also 99% sure the dead states aren't used because when a pai "dies" it just turns back into a card. You could remove those if you'd like.

@thgvr
Copy link
Member

thgvr commented Jan 15, 2024

Even if you just change the outline color to the same one as snake/frog it'd be better

@rye-rice
Copy link
Member

oh my god, thank you so much for making the screens a radial!

is there a way to display the screen underlaying the pAI radial? its a bit hard to see the emoticons just from the screen overlays

@Skies-Of-Blue
Copy link
Contributor Author

oh my god, thank you so much for making the screens a radial!

is there a way to display the screen underlaying the pAI radial? its a bit hard to see the emoticons just from the screen overlays

That's probably beyond my very limited abilities, but I'll give it a shot!

@Skies-Of-Blue
Copy link
Contributor Author

Unless any other issues come up, this should be ready for TM!

Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RADIALS ‼️

@thgvr thgvr added the Test Merge Candidate You do it for free. label Jan 30, 2024
@rye-rice rye-rice added this pull request to the merge queue Feb 5, 2024
Merged via the queue into shiptest-ss13:master with commit f77d063 Feb 5, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Feb 7, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Various ports, per request:
BeeStation/BeeStation-Hornet#4917 Crow
holochassis! (mycophobes stay winning)
BeeStation/BeeStation-Hornet#4944 Puppy
holochassis!
BeeStation/BeeStation-Hornet#5601 A smattering
of holochassis (no Bee or Ghost)! + inhands for all holochassis.
Rejoice!
tgstation/tgstation#52879 Radials for
holochassis selection!
BeeStation/BeeStation-Hornet#8269 Radials for
screen selection!
BeeStation/BeeStation-Hornet#8977 and a final
mothroach holochassis, for good luck.

Credit to Crushtoe, MistakeNot4892, and Pirill for the spritework!
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
These poor pAI players have been feeding on scraps for so long. Did you
know that less than half of our available holochassis were capable of
being held by players? No longer! Also swaps screen+chassis selection
over from lists to radials, because having a preview of what you're
selecting is nice, and it's 2024.

Here are the radials in action, as well as a teaser for a few of the new
holochassis:
![pAI Mains Eating Good
Tonight](https://github.com/shiptest-ss13/Shiptest/assets/86762641/3bac3242-e7f3-4ff1-8a4b-4a078c6f32e3)



<|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|><|>


<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
imageadd: several new pAI holochassis
imageadd: held sprites for every existing pAI holochassis
tweak: all pAI holochassis can now be held
tweak: pAI screen and holochassis selections are now radials instead of
lists
spellcheck: several instances of code are now feeling less michevious
:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Skies-Of-Blue <[email protected]>
Co-authored-by: thgvr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes. Test Merge Candidate You do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants