Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 2647 #2648

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fixes 2647 #2648

merged 1 commit into from
Jan 22, 2024

Conversation

SomeguyManperson
Copy link
Contributor

About The Pull Request

Arcane machine tried to smelt up to 10 sheets of material but the alloy smelting proc didn't get a smelting number passed so it just spawned 1 sheet and called it a day.

Why It's Good For The Game

fixes #2647

Changelog

🆑
fix: ore smelter no longer obliterates materials when smelting alloys
/:cl:

Signed-off-by: Theos <[email protected]>
@github-actions github-actions bot added the Code change Watch something violently break. label Jan 19, 2024
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ayyy

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Jan 22, 2024
Merged via the queue into shiptest-ss13:master with commit 1e4201a Jan 22, 2024
14 checks passed
@SomeguyManperson SomeguyManperson deleted the patch-2 branch January 24, 2024 18:25
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jan 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Arcane machine tried to smelt up to 10 sheets of material but the alloy
smelting proc didn't get a smelting number passed so it just spawned 1
sheet and called it a day.

## Why It's Good For The Game

fixes shiptest-ss13#2647

## Changelog

:cl:
fix: ore smelter no longer obliterates materials when smelting alloys
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Signed-off-by: Theos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Smeltery ate my materials like a faulty vending machine eats your coins
2 participants