-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUNS Part One: Clothing #2685
SUNS Part One: Clothing #2685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fucking BLESS YOU
maybe ask @meemofcourse for help with outfits? or is that out of scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are nice. if you want help with the outfits you can ping me on discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be sorted into factional files.
You can see an example of how this should be done with the Gezenan assets.
icons/mob/clothing/faction/...
icons/obj/clothing/faction/...
code/modules/clothing/faction/...
Co-authored-by: meem <[email protected]> Signed-off-by: Skies-Of-Blue <[email protected]>
Co-authored-by: meem <[email protected]> Signed-off-by: Skies-Of-Blue <[email protected]>
Co-authored-by: meem <[email protected]> Signed-off-by: Skies-Of-Blue <[email protected]>
Co-authored-by: meem <[email protected]> Signed-off-by: Skies-Of-Blue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all seems well! you forgot to draft for the outfits though
I see that Jotaro hat. |
PR ready for re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep once again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
Will thorougly go over this later today, if I don't shake me violently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna Drag a certain someone back to this server mark my words
heh. heh heh. |
wrong, aegis outfits |
oh right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks to make everyone's life easier down the line
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Picks up where the brave Draggeru left off, giving her sprites a second chance at life! More information can be found in the original PR shiptest-ss13#2439 <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> I want my pompous bastards and I want them NOW ![278865636-bde939c3-534a-4d05-b0a0-a782d611d4dd](https://github.com/shiptest-ss13/Shiptest/assets/86762641/c1dc3f65-5896-41ca-a475-aa0028aea1c4) Note: The majority of these items are still unimplemented, although some can now be found on the Aegis. The primary goal of this PR is to give future SUNS ships something to work with (and maybe allow for some cheeky events in the meantime) <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: Draggeru, Cre add: adds all of the clothing intended for SUNS, including uniforms for the captain, xo, cmo, scientists, miners, engineers, and doctors add: several job outfits to support future SUNS content /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Skies-Of-Blue <[email protected]> Co-authored-by: meem <[email protected]>
About The Pull Request
Picks up where the brave Draggeru left off, giving her sprites a second chance at life!
More information can be found in the original PR #2439
Why It's Good For The Game
I want my pompous bastards and I want them NOW
Note: The majority of these items are still unimplemented, although some can now be found on the Aegis. The primary goal of this PR is to give future SUNS ships something to work with (and maybe allow for some cheeky events in the meantime)
Changelog
🆑 Draggeru, Cre
add: adds all of the clothing intended for SUNS, including uniforms for the captain, xo, cmo, scientists, miners, engineers, and doctors
add: several job outfits to support future SUNS content
/:cl: