Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aegis QoL changes (community requests) #2709

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

fighterslam
Copy link
Contributor

@fighterslam fighterslam commented Feb 8, 2024

About The Pull Request

This is my first PR, in, like, 2 years. So maybe we're back?
EDIT: So. Initially, this was just a handful of community requests to the Aegis.
Now it has turned into a basic SUNS-ification PR for the vessel, stripping out all the old generic syndicate gear and replacing it all with SUNS stuff. Also slightly nerfs the vessel by removing a few traitor items, such as the dart pistol, night vision goggles, etc etc. But the drip compensates.

Why It's Good For The Game

The ship already has SUNS loadouts, now this just translates it to actual ship gear.

Changelog

🆑
:add: Strips out all the generic syndicate gear from the Aegis-Class and replaces it with SUNS gear. Hooray for student debt
/:cl:

@fighterslam fighterslam requested a review from a team as a code owner February 8, 2024 06:55
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Feb 8, 2024
@JimKil3
Copy link
Contributor

JimKil3 commented Feb 8, 2024

You should also swap out the tactical turtlenecks, combat boots, and such in the lockers in dorms with SUNS formal suits, SUNS dress shoes, etc. There's also some labcoats and nitrile gloves in the lockers in medical that could be swapped with their SUNS variants

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Feb 11, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Feb 11, 2024
Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, testing in round

@Latentish Latentish added this pull request to the merge queue Feb 11, 2024
Merged via the queue into shiptest-ss13:master with commit 59b4ff7 Feb 11, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Feb 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
This is my first PR, in, like, 2 years. So maybe we're back?
EDIT: So. Initially, this was just a handful of community requests to
the Aegis.
Now it has turned into a basic SUNS-ification PR for the vessel,
stripping out all the old generic syndicate gear and replacing it all
with SUNS stuff. Also slightly nerfs the vessel by removing a few
traitor items, such as the dart pistol, night vision goggles, etc etc.
But the drip compensates.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
The ship already has SUNS loadouts, now this just translates it to
actual ship gear.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
:add: Strips out all the generic syndicate gear from the Aegis-Class and
replaces it with SUNS gear. Hooray for student debt
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants