Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives the Riggs a touch-up #2721

Merged
merged 18 commits into from
Mar 27, 2024
Merged

Conversation

Apogee-dev
Copy link
Contributor

@Apogee-dev Apogee-dev commented Feb 11, 2024

About The Pull Request

rigger_remap
The Riggs has aged incredibly well for being one of the oldest maps still in rotation, but it's definitely fallen out of line with newer ships as standards have been updated. This PR brings it in line with those standards and freshens up the layout and decoration a bit.

  • Removed RnD and ORM
  • Added separate cryo room
  • Added crew lounge area and miner ready room
  • Moved atmos slightly to make accessing the empty rooms easier and replaced the standing air tanks with a 1-tile open air tank (temporary, really, until we get better tanks coded)
  • Added access restrictions to atmos and engine room (but not engineering bay)
  • Reduced miner slots to 1 and assistant slots to 2
  • Removed Mech Technician

Why It's Good For The Game

Riggs was getting crusty and needed some love.

Changelog

🆑
tweak: Made the Riggs-class sloop nicer to live in
balance: Removed RnD and ORM from the Riggs
/:cl:

deleted RnD, updated layout in general, brought in line with contemporary standards
@Apogee-dev Apogee-dev requested a review from a team as a code owner February 11, 2024 08:21
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Feb 11, 2024
@Apogee-dev Apogee-dev removed the Map Change Tile placing is hard. Thank you for your service. label Feb 11, 2024
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Feb 11, 2024
@west3436
Copy link

Why the slot reductions?

@meemofcourse
Copy link
Contributor

the riggs does not need 13 crewmembers. that's 3 less than the twink, with half the space

Copy link
Contributor

@meemofcourse meemofcourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen
consider breaking up the monotiling here
imagen
since you're removing RnD from the ship, i don't think it needs wayfinding beacons anymore
imagen
please unleash the cat from the closet
imagen
i think we agreed on not giving fax machines to independent ships, so please remove this fax machine

@Apogee-dev
Copy link
Contributor Author

Apogee-dev commented Feb 12, 2024

please unleash the cat from the closet

Jonesy is in the closet because there's no way for me to put her in cryo 😔

anyway I followed the other responses. Kept the nav beacons for simplebots though. Not too much reason not to have them since simplebots, particularly medbots, are so common and easy to get (just smash a malfunctioning one on a junkplanet) and the role of nav beacons is largely QoL

Copy link
Contributor

@meemofcourse meemofcourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sealed forever

@Apogee-dev Apogee-dev added Test Merge Required They'll have to do it for free. Ship Ship successfully tested. labels Feb 28, 2024
@Latentish
Copy link
Member

TM Ready I think

@XxNinMario64xX
Copy link

Mech Technician (or whatever it's called) feels like an unnecessary job now due to having no ability to construct more mechs. Just call them an engineer and don't imply they can create more mechs, as people will join the riggs thinking they can build more than a Ripley during the round unless there's a way to give the ability to create more mechs without re-adding R&D.

@Apogee-dev
Copy link
Contributor Author

Mech Technician (or whatever it's called) feels like an unnecessary job now due to having no ability to construct more mechs. Just call them an engineer and don't imply they can create more mechs, as people will join the riggs thinking they can build more than a Ripley during the round unless there's a way to give the ability to create more mechs without re-adding R&D.

The mech technician was removed along with the reductions in other job slots.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Mar 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Mar 12, 2024
Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement. Tested on live, found no issues.

@Latentish Latentish added this pull request to the merge queue Mar 27, 2024
@Latentish
Copy link
Member

marg

Merged via the queue into shiptest-ss13:master with commit 6b6467d Mar 27, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![rigger_remap](https://github.com/shiptest-ss13/Shiptest/assets/60533805/53fce13e-7ed8-46de-a878-077bf0614077)
The Riggs has aged incredibly well for being one of the oldest maps
still in rotation, but it's definitely fallen out of line with newer
ships as standards have been updated. This PR brings it in line with
those standards and freshens up the layout and decoration a bit.

- Removed RnD and ORM
- Added separate cryo room
- Added crew lounge area and miner ready room
- Moved atmos slightly to make accessing the empty rooms easier and
replaced the standing air tanks with a 1-tile open air tank (temporary,
really, until we get better tanks coded)
- Added access restrictions to atmos and engine room (but not
engineering bay)
- Reduced miner slots to 1 and assistant slots to 2
- Removed Mech Technician

## Why It's Good For The Game

Riggs was getting crusty and needed some love.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: Made the Riggs-class sloop nicer to live in
balance: Removed RnD and ORM from the Riggs
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 15, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![rigger_remap](https://github.com/shiptest-ss13/Shiptest/assets/60533805/53fce13e-7ed8-46de-a878-077bf0614077)
The Riggs has aged incredibly well for being one of the oldest maps
still in rotation, but it's definitely fallen out of line with newer
ships as standards have been updated. This PR brings it in line with
those standards and freshens up the layout and decoration a bit.

- Removed RnD and ORM
- Added separate cryo room
- Added crew lounge area and miner ready room
- Moved atmos slightly to make accessing the empty rooms easier and
replaced the standing air tanks with a 1-tile open air tank (temporary,
really, until we get better tanks coded)
- Added access restrictions to atmos and engine room (but not
engineering bay)
- Reduced miner slots to 1 and assistant slots to 2
- Removed Mech Technician

## Why It's Good For The Game

Riggs was getting crusty and needed some love.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: Made the Riggs-class sloop nicer to live in
balance: Removed RnD and ORM from the Riggs
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants