Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe fixes fishing #2739

Merged
merged 3 commits into from
Mar 4, 2024
Merged

maybe fixes fishing #2739

merged 3 commits into from
Mar 4, 2024

Conversation

thgvr
Copy link
Member

@thgvr thgvr commented Feb 17, 2024

About The Pull Request

This might fix fishing it worked locally

Changelog

🆑
fix: Fishing shouldn't fail constantly anymore
fix: Fish on the floor will die again
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Feb 17, 2024
@SomeguyManperson
Copy link
Contributor

I don't believe the problem occurs locally from personal testing, I've only been able to reproduce it on the live server

@thgvr
Copy link
Member Author

thgvr commented Feb 17, 2024

Yeah but this fixes fish not dying on the floor at least. I don't have any idea what's going on otherwise

@github-actions github-actions bot added the TGUI label Feb 17, 2024
@MarkSuckerberg
Copy link
Member

did it work

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Mar 4, 2024
Merged via the queue into shiptest-ss13:master with commit a11ba58 Mar 4, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Mar 5, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
This might fix fishing it worked locally
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Changelog

:cl:
fix: Fishing shouldn't fail constantly anymore
fix: Fish on the floor will die again
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants