-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I Left My Heart In Kalixcis [PGF] Crying Sun-Class Light Frigate #2742
I Left My Heart In Kalixcis [PGF] Crying Sun-Class Light Frigate #2742
Conversation
titular
- enables the gevena flag - adds most of the ship
-Titular
Remind me to update the kalixcis laser gun balance in a bit @coleminerman |
-separates the shuttle and ship -fleshes out both maps
This PR is waiting on some assets and should not be full-merged until they are ready. |
-connects a scrubber
fixes a couple minor wiring issues
- replaces the glass thindows in the engine room with reinforced plasmaglass
-they are now here....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patches
Sabre sheathe populates with a sabre already in it.
Captains room has Syndicate secret documents.
Jumbo's bed needs to be anchored or it can just be moved around by him.
Bridge needs access restrictions.
Make the helm a metal console like the rest of them.
Crates do not map onto crate shelves. Change the layout and remove some of the empty/useless crates as it is annoying to move every crate in order to stack them onto the shelves. Give the airlock in this room an SSU and an oxygen closet. It doesn't function without the distro pump on.
This pump needs to be on for the airlocks to function.
Relay doesn't seem to be working. Might be an issue on my end.
It's standard practice to include directional windows between the thruster and precharger/preheater. It looks weird without them.
What is the purpose of this pipe contraption? And why is this room's area "Electrical" despite being an engine? I seriously reccomend replacing this... contraption with just a straight plasma pipe into the engine and use the space for other things.
Use the /inherit type of SSU to have suits start inside them (do this in the armory as well). I am not sure why you have a wrench on top of the engine that already starts as anchored. I am also not sure if a single plasma engine will be able to support the power demands of this ship (update, it cant. 14kw passive draw and ~35kw active draw).
Umm. I think this may have the wrong icon state.
I take back what I said about putting the toy gun vendor in the armory. It looks extremely out of place and I don't want marines thinking that they're supposed to use these as weapons. Maybe just move it behind the sergeants desk.
Put some glass and a windoor up so marines can't just hop the table. Sergeant and Marine lockers are missing capes, unsure if its intentional.
Exterior hull platings start airless and cause spacewind when the hall doors open. They also will cause pressure issues when the ship docks due to them carrying the vacuum with them when they dock.
Nail is missing an air alarm. Put something on those empty spaces where the terminals to the prechargers go, SSUs or crates/lockers or something.
This room feels like it could use more. Maybe add some trays/trash/kitchenware. Needs a salt and pepper shaker so they can actually make eggs. By the way, that fridge subtype stocks itself with a lot of eggs and milk on in it, maybe replace it with a meat-freezer type. If this isn't intentional then give them WAY more rations because 3 is not enough for the entire crew.
Notes
The ship feels very overstocked. Having spare equipment for every single crewmember and then some is excessive. Like holy fucking shit excessive.
"Spare" EVA Closet with SIX SETS OF SUITS
Dial it back. You at most need 2 maybe 3 spares for any role with more than 3 people.
The armory has ~8 spare sets of armor (coated vests+normal vests and helmets+caps) for THREE MARINES.
On a different note, this vessel could use some direction, as people likely won't know how to play PGF well for a while. I'd make it adminspawn (for admin-curated testing) as well as having a lore writer draft you up some documents to place onto the vessel for players to read. Perhaps something regarding the capes being an essential rank display, potential missions for the crew to seek out, or just something to promote roleplaying as a marine/navy unit.
Good Things
I love the color palette of the vessel. The teals and greens really make it feel unique compared to any other factions.
Look at this team of kobolds I've hired to kill you. PGF drip is splendid.
I love this. Beautiful work making wall lockers as not-shit as you can.
Finally, Synthetic inclusion bunks.
Fix as many of the most pressing issues you can and we can TM this on Wednesday or Friday.
- Tweaked the kitchen - Added an Air Alarm to the Nail - Removed 3 out of the 4 externals plates on the Nail, making the last one a /internal - Swapped out the plasma gen for a uraniumgem - Added atmos and an air alarm to the nail - Replaced the security computer with the donksoft vendor - Placed 5 seclites and GPS's - Replaced cryo gear for 5 radios, 6 headsets, and 8 incryption keys - Fixed the locker sprites - Added some thindows - removed FREQ_COMMON from all faction radios - swapped air distro pump with /on variant - added oxy closet to airlock - cleaned up the construction room and decalled the floor - Swapped the computer in the helm for a normal metal console - Added a Bridge officer Job - Access Locked the Bridge - Removed the extra saber and secret documents - Added more stuff to the mess hall - swapped out the 6 rakalla suits for 4 eva suits - Cut Armory armor counts in half - Aspawned the vehicle - Added a book about the decommissioned weapon mount.
- yeah
Emotion42
- Changes the armory up - adds some exterior hull plating - adds some mats - adds a cell recharger to the armory - adds a crate and rack to the nail - swaps the cloak on the bridge officer for a /captain variant - it really makes you feel like liards
- adds an extra helmet and a hand labeller to the armory - adds 2 holopads
- Adds a PGF namelist - Tweaks the shutters - Adds a "Mission Accomplished" posterset in the construction bay - Sets ship funds to 1000, leaves 1000 cash in captain's quarters
it also adds a space in the PGF namelist declaration
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- adds my changes to the merge patch
- yeah makes it aspawn only
- lowers bridge officer slots to 1 - raises crewman slots to 2
- changes the name of the sergeant's azuilhauz - changes up the clothes on the ship to reflect the new gear - changes out bridge officer slots for bridge crew slots - adds a bridge crew outfit.
- adds job specific backpacks to every job type except the assistant ones. - adds the sepcial boxes for each job outfit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't wait to kiss lizards on this ship
…ptest-ss13#2742) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Adds the PGF's first ship. The Crying Sun-class Light Frigate. It also adds some sprite.... <details> <summary>In Game</summary> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/95eb7495-650e-47f5-a2e0-866c7b7c078c"> </details> <details> <summary>Areas</summary> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/3cb573d4-ea68-46f1-84a9-f3ef9e295bc9"> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/54e1924f-2910-45f1-a473-28330099404e"> </details> <details> <summary>No Areas</summary> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/ba149f83-9652-48f1-b621-7fb718325304"> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/48e55987-e2db-4e6c-a83b-140be5863c4c"> </details> <details> <summary>Icons</summary> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/24a4f332-39b4-4d8a-877c-6297b715de3b"> Mission Accomplished Poster by Retlaw34 <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/d43f8dfb-a501-4126-a31a-5dbc78165ed2"> Etherbor Logo by Coleminerman </details> Thanks to MeeMofCourse for the book formatting. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Represents a previously unplayable faction with a new ship. Todo: - [x] Add Sergeant Clothes. - [x] Describe her. - [x] Add fluff notes - [x] Add Mission Accomplished poster set - [x] Change the name - [x] Add new sidearm when it's merged. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl:phoaly, coleminerman, MeeMofCourse, Retlaw34 add: Added the Crying Sun-class add: Added PGF comms icon: Added PGF sprites /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
…ptest-ss13#2742) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Adds the PGF's first ship. The Crying Sun-class Light Frigate. It also adds some sprite.... <details> <summary>In Game</summary> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/95eb7495-650e-47f5-a2e0-866c7b7c078c"> </details> <details> <summary>Areas</summary> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/3cb573d4-ea68-46f1-84a9-f3ef9e295bc9"> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/54e1924f-2910-45f1-a473-28330099404e"> </details> <details> <summary>No Areas</summary> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/ba149f83-9652-48f1-b621-7fb718325304"> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/48e55987-e2db-4e6c-a83b-140be5863c4c"> </details> <details> <summary>Icons</summary> <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/24a4f332-39b4-4d8a-877c-6297b715de3b"> Mission Accomplished Poster by Retlaw34 <img src="https://github.com/shiptest-ss13/Shiptest/assets/55075747/d43f8dfb-a501-4126-a31a-5dbc78165ed2"> Etherbor Logo by Coleminerman </details> Thanks to MeeMofCourse for the book formatting. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Represents a previously unplayable faction with a new ship. Todo: - [x] Add Sergeant Clothes. - [x] Describe her. - [x] Add fluff notes - [x] Add Mission Accomplished poster set - [x] Change the name - [x] Add new sidearm when it's merged. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl:phoaly, coleminerman, MeeMofCourse, Retlaw34 add: Added the Crying Sun-class add: Added PGF comms icon: Added PGF sprites /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
About The Pull Request
Adds the PGF's first ship. The Crying Sun-class Light Frigate. It also adds some sprite....
In Game
Areas
No Areas
Icons
Mission Accomplished Poster by Retlaw34 Etherbor Logo by ColeminermanWhy It's Good For The Game
Represents a previously unplayable faction with a new ship.
Todo:
Changelog
🆑phoaly, coleminerman, MeeMofCourse, Retlaw34
add: Added the Crying Sun-class
add: Added PGF comms
icon: Added PGF sprites
/:cl: