Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Lobotomy" with more reliable "Advanced Neurosurgery" surgery. #2757

Closed
wants to merge 0 commits into from

Conversation

XxNinMario64xX
Copy link

@XxNinMario64xX XxNinMario64xX commented Feb 23, 2024

About The Pull Request

  • Removes Lobotomies as a surgery option and removes them from the research pool
  • Adds the "Advanced Neurosurgery" option in place of Lobotomy, which is a much safer, lengthier and healthier way of getting rid of deep-rooted traumas. (Does not work on permanent traumas).

Why It's Good For The Game

Making lobotomies the only way to get rid of deep rooted trauma is just a terrible design decision due to how crippling its traumas are. Also generally speaking here: lobotomies will not give you superpowers, or anyone superpowers for that matter. They do not magically heal deep-rooted traumas and suddenly allow you to speak the language of gods.

So for the sake of realism, let's just remove them and replace it with something better.

Advanced Neurosurgery is a far more interesting surgery subtype that affects the brain and general nervous-system. It's far more realistic towards a better form of brain surgery as most brain surgeries are some form of Neurosurgery.

Neurosurgery also leaves a lot of room for more surgeries to be built around it in the future, affecting the brain in positive ways rather than risking more and more permanent traumas every attempt. It takes much longer to do, as it's a precise surgery that requires a hemostat. As an upside to its long surgery duration, it also gives more Healing skill EXP.

Changelog

🆑
del: Lobotomy tech from research tech tree
add: "Advanced Neurosurgery" surgery in tech tree (Under Advanced Surgery)
/:cl:

@github-actions github-actions bot added DME Edit Code change Watch something violently break. labels Feb 23, 2024
@Zevotech Zevotech added the Good First PR There's only one way and it's up! label Feb 23, 2024
@Zevotech
Copy link
Contributor

its del: instead of rem: in the changelog for removals here, but otherwise very good reasoning and PR.

experience_given = MEDICAL_SKILL_ADVANCED //lose XP if you end up giving them bad traumas

/datum/surgery_step/advanced_neurosurgery/tool_check(mob/user, obj/item/tool)
if(implement_type == /obj/item && !tool.get_sharpness())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont think this proc is required since hemostats arent sharp & there arent any improvised analogues for the surgery


/datum/surgery_step/advanced_neurosurgery/failure(mob/user, mob/living/carbon/target, target_zone, obj/item/tool, datum/surgery/surgery)
var/obj/item/organ/brain/B = target.getorganslot(ORGAN_SLOT_BRAIN)
if(B)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont see a failure effect?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just waiting on this, whether adding the failure effects or revising the results language, the rest is good

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs an effect faliure

if(target.mind && target.mind.has_antag_datum(/datum/antagonist/brainwashed))
target.mind.remove_antag_datum(/datum/antagonist/brainwashed)
target.gain_trauma_type(BRAIN_TRAUMA_MILD, TRAUMA_RESILIENCE_MAGIC)
experience_given = MEDICAL_SKILL_ADVANCED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant line since the experience gain is advanced by default

@XxNinMario64xX
Copy link
Author

@SomeguyManperson Cut out redundant lines and removed gaining a trauma if the target is brainwashed. The possibility for a failed surgery still results in possible permanent brain trauma, though the odds are extremely low given the high success rate when using a hemostat.

@Imaginos16
Copy link
Member

Me after the lobotomy 😂 😂 😂 😂

@Cadunkus
Copy link
Contributor

Cool and all except the tech tree is going the way of the dodo so don't expect this to last long.

@XxNinMario64xX
Copy link
Author

That's very fair. I won't add stuff to the tech tree then and just leave it as is till R&D gets touched on.


/datum/surgery_step/advanced_neurosurgery/failure(mob/user, mob/living/carbon/target, target_zone, obj/item/tool, datum/surgery/surgery)
var/obj/item/organ/brain/B = target.getorganslot(ORGAN_SLOT_BRAIN)
if(B)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just waiting on this, whether adding the failure effects or revising the results language, the rest is good

Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just needs the fail effect.


/datum/surgery_step/advanced_neurosurgery/failure(mob/user, mob/living/carbon/target, target_zone, obj/item/tool, datum/surgery/surgery)
var/obj/item/organ/brain/B = target.getorganslot(ORGAN_SLOT_BRAIN)
if(B)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs an effect faliure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Good First PR There's only one way and it's up!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants