Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play local sound volume #2772

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Play local sound volume #2772

merged 2 commits into from
Mar 14, 2024

Conversation

cuddleandtea
Copy link
Contributor

About The Pull Request

Adds volume settings for Fun>Play local music
image

Why It's Good For The Game

Just imagine how good this is to not change volume of each track by yourself in some adobe audition.

Changelog

🆑
add: volume setting for play local sound
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Feb 27, 2024
@thgvr
Copy link
Member

thgvr commented Mar 12, 2024

Address review and i'll merge

@cuddleandtea
Copy link
Contributor Author

Address review and i'll merge

Seems that I can just ask for re-review

@MarkSuckerberg MarkSuckerberg added the Good First PR There's only one way and it's up! label Mar 13, 2024
MarkSuckerberg
MarkSuckerberg approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Mar 14, 2024
Merged via the queue into shiptest-ss13:master with commit 9e0c992 Mar 14, 2024
14 checks passed
shiptest-server pushed a commit that referenced this pull request Mar 14, 2024
@actions-user
Automatic changelog generation for PR #2772 [ci skip]
c3d7905
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Mar 23, 2024
@cuddleandtea @MarkSuckerberg @MysticalFaceLesS
Play local sound volume (shiptest-ss13#2772)
88d2a64 
Adds volume settings for Fun>Play local music

![image](https://github.com/MysticalFaceLesS/Shiptest/assets/105150564/e2b931fd-82cf-47ff-8b62-fbbd44d6a477)

Just imagine how good this is to not change volume of each track by
yourself in some adobe audition.

:cl:
add: volume setting for play local sound
/:cl:

---------

Signed-off-by: Mark Suckerberg <[email protected]>
Co-authored-by: Mark Suckerberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkSuckerberg MarkSuckerberg MarkSuckerberg approved these changes

Assignees
No one assigned
Labels
Code change Watch something violently break. Good First PR There's only one way and it's up!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuddleandtea @thgvr @MarkSuckerberg