Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some cargo gun descriptions and lowers 38 ammo price. #2777

Merged
merged 13 commits into from
May 20, 2024

Conversation

Martinpachu
Copy link
Contributor

@Martinpachu Martinpachu commented Feb 28, 2024

About The Pull Request

As the name says.

Why It's Good For The Game

38 Special is supposed to be the cheapest ammo, doing the same damage as 9mm rounds and has guns either with low ammo capacity, or that need to be pumped after every shot. Also i fucked some things up in my last PR. sorry. sorry. im so stupid. dont hit me with the tail.

Changelog

🆑
balance: .38 ammo boxes are cheaper.
spellcheck: Fixed some cargo gun descriptions.
fix: Fixed an issue regarding multiple stechkin pistols in a singular cargo pack.
🆑

@github-actions github-actions bot added Code change Watch something violently break. Merge Conflict Use Git Hooks, you're welcome. labels Feb 28, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Mar 5, 2024
@Martinpachu
Copy link
Contributor Author

conflict's fixed!

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Mar 15, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just this one thing

code/modules/cargo/packs/gun.dm Outdated Show resolved Hide resolved
Co-authored-by: Mark Suckerberg <[email protected]>
Signed-off-by: Martinpachu <[email protected]>
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Apr 30, 2024
@Martinpachu
Copy link
Contributor Author

fixed this finally

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 5, 2024
Copy link
Contributor

github-actions bot commented May 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label May 5, 2024
@Martinpachu
Copy link
Contributor Author

fixed...again.. fuck!!

Copy link
Contributor

github-actions bot commented May 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 8, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label May 9, 2024
@rye-rice rye-rice added this pull request to the merge queue May 20, 2024
Merged via the queue into shiptest-ss13:master with commit b898359 May 20, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request May 25, 2024
…-ss13#2777)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

As the name says.

## Why It's Good For The Game

38 Special is supposed to be the cheapest ammo, doing the same damage as
9mm rounds and has guns either with low ammo capacity, or that need to
be pumped after every shot. Also i fucked some things up in my last PR.
sorry. sorry. im so stupid. dont hit me with the tail.

## Changelog

:cl:
balance: .38 ammo boxes are cheaper.
spellcheck: Fixed some cargo gun descriptions.
fix: Fixed an issue regarding multiple stechkin pistols in a singular
cargo pack.
:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Martinpachu <[email protected]>
Co-authored-by: Mark Suckerberg <[email protected]>
Co-authored-by: Theos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants