-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds more ways to ignite e-cigarettes. #2796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lets GOOOOOO HELL YEAH |
make it so you can light them on elzuosa |
Mmm, not really a fan of that idea. Feel free to open a follow-up PR if you want to see that happen though. |
thgvr
reviewed
Mar 9, 2024
shiptest-server
pushed a commit
that referenced
this pull request
Mar 12, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Mar 23, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Do you want your character to vape, but did they not spawn with a PDA? Well, worry not, this PR adds new ways to ignite your e-cigarettes/e-cigars! First one, is with a tablet. Works essentially the same as with a PDA. There is way more jobs that get a free tablet than those that get a PDA. Plus, you can get those from loadout. Second one, is with an APC. Smash your vape on the APC and it will get ignited! How does it work? Clearly designers were just very thoughtful and included a vape igniter or whatever you use! <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Items being actually usable is nice. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: tweak: E-cigarettes and e-cigars can now be turned on with tablets and APCs. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Do you want your character to vape, but did they not spawn with a PDA? Well, worry not, this PR adds new ways to ignite your e-cigarettes/e-cigars!
First one, is with a tablet. Works essentially the same as with a PDA. There is way more jobs that get a free tablet than those that get a PDA. Plus, you can get those from loadout.
Second one, is with an APC. Smash your vape on the APC and it will get ignited! How does it work? Clearly designers were just very thoughtful and included a vape igniter or whatever you use!
Why It's Good For The Game
Items being actually usable is nice.
Changelog
🆑
tweak: E-cigarettes and e-cigars can now be turned on with tablets and APCs.
/:cl: