Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more ways to ignite e-cigarettes. #2796

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

Sadhorizon
Copy link
Contributor

@Sadhorizon Sadhorizon commented Mar 2, 2024

About The Pull Request

Do you want your character to vape, but did they not spawn with a PDA? Well, worry not, this PR adds new ways to ignite your e-cigarettes/e-cigars!

First one, is with a tablet. Works essentially the same as with a PDA. There is way more jobs that get a free tablet than those that get a PDA. Plus, you can get those from loadout.

Second one, is with an APC. Smash your vape on the APC and it will get ignited! How does it work? Clearly designers were just very thoughtful and included a vape igniter or whatever you use!

Why It's Good For The Game

Items being actually usable is nice.

Changelog

🆑
tweak: E-cigarettes and e-cigars can now be turned on with tablets and APCs.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Mar 2, 2024
@Sweettoothart
Copy link

lets GOOOOOO HELL YEAH

@KittyNoodle
Copy link
Contributor

make it so you can light them on elzuosa

@Sadhorizon
Copy link
Contributor Author

Sadhorizon commented Mar 4, 2024

make it so you can light them on elzuosa

Mmm, not really a fan of that idea.

Feel free to open a follow-up PR if you want to see that happen though.

@thgvr thgvr added this pull request to the merge queue Mar 12, 2024
Merged via the queue into shiptest-ss13:master with commit 0b3cc92 Mar 12, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Mar 23, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Do you want your character to vape, but did they not spawn with a PDA?
Well, worry not, this PR adds new ways to ignite your
e-cigarettes/e-cigars!

First one, is with a tablet. Works essentially the same as with a PDA.
There is way more jobs that get a free tablet than those that get a PDA.
Plus, you can get those from loadout.

Second one, is with an APC. Smash your vape on the APC and it will get
ignited! How does it work? Clearly designers were just very thoughtful
and included a vape igniter or whatever you use!

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Items being actually usable is nice.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: E-cigarettes and e-cigars can now be turned on with tablets and
APCs.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants