Tweaks plasma thrusters #2797
Merged
Tweaks plasma thrusters #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Mar 5, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Changes how plasma thrusters calculate the maximum amount of fuel they can store. Instead of using the heater's volume, they now use an amount of moles based on standard conditions for plasma thrusters - if you cool down your plasma or refit your ship to more efficiently fill the thrusters than with a standard gas pump, you can still get numbers over 100% (just like you can with ion engines if you directly connect them to a grid). <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Plasma thrusters showing like 180% with a default setup hurts my soul and is also pretty unintuitive. With these changes, you can still tweak your thrusters to be more efficient - for default plasma thrusters though, this makes their display more useful. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: tweak: Plasma thrusters now have a more sensible fuel readout /🆑 <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Changes how plasma thrusters calculate the maximum amount of fuel they can store. Instead of using the heater's volume, they now use an amount of moles based on standard conditions for plasma thrusters - if you cool down your plasma or refit your ship to more efficiently fill the thrusters than with a standard gas pump, you can still get numbers over 100% (just like you can with ion engines if you directly connect them to a grid).
Why It's Good For The Game
Plasma thrusters showing like 180% with a default setup hurts my soul and is also pretty unintuitive. With these changes, you can still tweak your thrusters to be more efficient - for default plasma thrusters though, this makes their display more useful.
Changelog
🆑
tweak: Plasma thrusters now have a more sensible fuel readout
/🆑