-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prosthesis Changes & Mechanical Surgery Tweaks #2804
Merged
thgvr
merged 5 commits into
shiptest-ss13:master
from
Skies-Of-Blue:prosthetic-maint-rp-pwease
Mar 12, 2024
Merged
Prosthesis Changes & Mechanical Surgery Tweaks #2804
thgvr
merged 5 commits into
shiptest-ss13:master
from
Skies-Of-Blue:prosthetic-maint-rp-pwease
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimKil3
reviewed
Mar 6, 2024
Removes the ability to remove robotic heads, allowing FBPs to kill themselves instantly.
If no other issues are reported this uptime, this PR should be more or less ready to merge. I know #2811 is waiting on this to go through for their own work. |
shiptest-server
pushed a commit
that referenced
this pull request
Mar 12, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Mar 23, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Kept you waiting, huh? Firstly, the smaller changes: - Prosthesis organ manipulation now uses a crowbar instead of a hemostat to remove organs. This was one of two instances of surgical tools being required for IPC Surgery, and it always felt out of place. - Adds a new surgery step, "Close hatch," has been added to most mechanical surgeries for the sake of consistency. This affects implant removal, ipc revival, mechanical brain surgery, and prosthesis organ manipulation. The new steps can be found in the changelog. - Removes player-facing access to chainsaw arms and synthetic arm blades. They always felt ill-fitting for our setting. The code remains, though, just in case someone wants to add untraditional limbs in the future. And now, for the main course: This PR creates two new surgeries, Detach Prosthesis and Prosthesis Attachment, which allow any character with a prosthesis to remove and attach it themself with a set of basic tools. Additionally, it renames Prosthetic Replacement surgery to Limb Grafting surgery, to better reflect its new role as the more surgical variant of limb attachments. Limb Grafting retains all of its previous functionality, minus chainsaw attachments. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Hoo boy, this PR was a long time coming. It's always been silly to me that characters are forced to keep their prostheses on 24/7. I can't imagine how uncomfortable that must get. Being forced to have a surgeon remove your leg (or to chop it off with something sharp!!!) just to give their residual limb a breather has always been stifling for prosthesis-based roleplay. This should hopefully open up more options for player expression, and help distinguish standard limbs from mechanical ones. The two new procedures added serve as alternatives for the more surgical Amputation/Grafting duo we've all grown to know and resent, rather than an outright replacement. It's 505 FSC, and prostheses can range from Glorified Peg Leg all the way to Fully Mobile Prosthetic Hand With Synthetic Nerves. As such, I think it's important to keep a couple variants of surgery around for that mechanical expression, even if they end with the same result. This also allows the Friendly Neighborhood Li-Teg to charge extra for limb grafting surgery as opposed to a basic prosthesis attachment procedure :) It's always bugged me that IPCs had to use a hemostat to remove their organs, and I've heard that annoyed sentiment echoed in others over the years. Swapping it gives more consistency to their mechanics overall, and allows for more IPCs to horrifically disassemble themselves as a form of self-soothing while the captain watches in awe. Lastly, chainsaw arms were a meme and have always felt too /TG/ for our setting. Were Shiptest a codebase built from the ground up, I doubt we would have ever seen these added to the game. I know some players expressed interest in having surplus limbs be attach/removable without tools of any sort, but due to time constraints and a general lack of my own abilities, that remains out of reach for the time being. Maybe I'll look into it in the future, who knows. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: add: creates close_hatch, a step that mirrors open_hatch in prosthetic surgeries for the sake of consistency. Why you leaving that hatch open?? The final step before screwing to finish surgery. This affects implant removal, ipc revival, mechanical brain surgery, and prosthesis organ manipulation add: creates manipulate_organs/mechanic, a step that swaps the necessary implements in synthetic surgery. Use a crowbar instead of a hemostat to remove any organs on an augmented limb! tweak: changes implant removal surgery to reflect the above. The new tool order is as follows: screwdriver, hand, wrench, crowbar, wrench, hand, screwdriver tweak: changes the (unused) ipc revival surgery to reflect the above. The new tool order is as follows: screwdriver, hand, multitool, inducer, hand, screwdriver tweak: changes mechanical brain surgery to reflect the above. The new tool order is as follows: screwdriver, hand, multitool, hemostat, hand, screwdriver tweak: changes prosthesis organ manipulation to reflect the above. The new tool order is as follows: screwdriver, hand, wrench (if head/chest), multitool, crowbar, wrench (if head/chest), hand, screwdriver add: creates the Detach Prosthesis surgery, a less violent alternative to Amputation. This allows for prosthesis users to remove their own limbs, for the purposes of maintenance or just plain comfort! The tool order is as follows: screwdriver, hand, multitool, wrench, crowbar/wrench/hand (so you can flavor how you remove the limb) tweak: changes the Prosthetic Replacement surgery, renaming it to Limb Grafting surgery. The steps remain the same, but the name needed some retooling, as the procedure is much more surgically involved than its new sibling: add: creates Prosthesis Attachment surgery, a less surgically involved version of the Limb Grafting surgery. This allows for people with prostheses to re-attach the limb they took off with Prosthesis Removal! The tool order is as follows: wrench, multitool, plug in prosthesis, hand, screwdriver del: removes the chainsaw and synthetic arm blade from being viable prostheses. Left the code intact in case someone wants to do something similar in-future /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Kept you waiting, huh?
Firstly, the smaller changes:
And now, for the main course:
This PR creates two new surgeries, Detach Prosthesis and Prosthesis Attachment, which allow any character with a prosthesis to remove and attach it themself with a set of basic tools.
Additionally, it renames Prosthetic Replacement surgery to Limb Grafting surgery, to better reflect its new role as the more surgical variant of limb attachments. Limb Grafting retains all of its previous functionality, minus chainsaw attachments.
Why It's Good For The Game
Hoo boy, this PR was a long time coming.
It's always been silly to me that characters are forced to keep their prostheses on 24/7. I can't imagine how uncomfortable that must get. Being forced to have a surgeon remove your leg (or to chop it off with something sharp!!!) just to give their residual limb a breather has always been stifling for prosthesis-based roleplay. This should hopefully open up more options for player expression, and help distinguish standard limbs from mechanical ones.
The two new procedures added serve as alternatives for the more surgical Amputation/Grafting duo we've all grown to know and resent, rather than an outright replacement. It's 505 FSC, and prostheses can range from Glorified Peg Leg all the way to Fully Mobile Prosthetic Hand With Synthetic Nerves. As such, I think it's important to keep a couple variants of surgery around for that mechanical expression, even if they end with the same result. This also allows the Friendly Neighborhood Li-Teg to charge extra for limb grafting surgery as opposed to a basic prosthesis attachment procedure :)
It's always bugged me that IPCs had to use a hemostat to remove their organs, and I've heard that annoyed sentiment echoed in others over the years. Swapping it gives more consistency to their mechanics overall, and allows for more IPCs to horrifically disassemble themselves as a form of self-soothing while the captain watches in awe.
Lastly, chainsaw arms were a meme and have always felt too /TG/ for our setting. Were Shiptest a codebase built from the ground up, I doubt we would have ever seen these added to the game.
I know some players expressed interest in having surplus limbs be attach/removable without tools of any sort, but due to time constraints and a general lack of my own abilities, that remains out of reach for the time being. Maybe I'll look into it in the future, who knows.
Changelog
🆑
add: creates close_hatch, a step that mirrors open_hatch in prosthetic surgeries for the sake of consistency. Why you leaving that hatch open?? The final step before screwing to finish surgery. This affects implant removal, ipc revival, mechanical brain surgery, and prosthesis organ manipulation
add: creates manipulate_organs/mechanic, a step that swaps the necessary implements in synthetic surgery. Use a crowbar instead of a hemostat to remove any organs on an augmented limb!
tweak: changes implant removal surgery to reflect the above. The new tool order is as follows: screwdriver, hand, wrench, crowbar, wrench, hand, screwdriver
tweak: changes the (unused) ipc revival surgery to reflect the above. The new tool order is as follows: screwdriver, hand, multitool, inducer, hand, screwdriver
tweak: changes mechanical brain surgery to reflect the above. The new tool order is as follows: screwdriver, hand, multitool, hemostat, hand, screwdriver
tweak: changes prosthesis organ manipulation to reflect the above. The new tool order is as follows: screwdriver, hand, wrench (if head/chest), multitool, crowbar, wrench (if head/chest), hand, screwdriver
add: creates the Detach Prosthesis surgery, a less violent alternative to Amputation. This allows for prosthesis users to remove their own limbs, for the purposes of maintenance or just plain comfort! The tool order is as follows: screwdriver, hand, multitool, wrench, crowbar/wrench/hand (so you can flavor how you remove the limb)
tweak: changes the Prosthetic Replacement surgery, renaming it to Limb Grafting surgery. The steps remain the same, but the name needed some retooling, as the procedure is much more surgically involved than its new sibling:
add: creates Prosthesis Attachment surgery, a less surgically involved version of the Limb Grafting surgery. This allows for people with prostheses to re-attach the limb they took off with Prosthesis Removal! The tool order is as follows: wrench, multitool, plug in prosthesis, hand, screwdriver
del: removes the chainsaw and synthetic arm blade from being viable prostheses. Left the code intact in case someone wants to do something similar in-future
/:cl: