Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pAI Update: NO GODS NO KINGS NO MASTERS & A Couple Radio Fixes #2806

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

Skies-Of-Blue
Copy link
Contributor

@Skies-Of-Blue Skies-Of-Blue commented Mar 5, 2024

About The Pull Request

Ports:

Why It's Good For The Game

pAIs are in a weird space of being the only positronic in-setting who MUST bound to a master by law. That doesn't really gel with the rest of our lore. Giving installers the ability to remove that Master-Servant relationship would be nice I think, especially considering pAIs tend to ignore it anyways.

Also bugs are bad, okay?

Changelog

🆑
add: a pAI's master can now clear the pAI's zeroth law
fix: pAIs are now able to fully utilize installed encryption keys through their integrated transceiver's menu when they have the encryption key software upgrade
fix: binary encryption keys work in pAIs that have downloaded the encryption key software
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Mar 5, 2024
@Skies-Of-Blue Skies-Of-Blue changed the title pAI Update: NO GODS NO KINGS NO MASTERS & a couple radio fixes pAI Update: NO GODS NO KINGS NO MASTERS & A Couple Radio Fixes Mar 5, 2024
@thgvr thgvr added this pull request to the merge queue Mar 12, 2024
Merged via the queue into shiptest-ss13:master with commit 2d6b011 Mar 12, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Mar 23, 2024
…est-ss13#2806)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Ports:
- BeeStation/BeeStation-Hornet#4990
- tgstation/tgstation#55215
- tgstation/tgstation#57033
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
pAIs are in a weird space of being the only positronic in-setting who
MUST bound to a master by law. That doesn't really gel with the rest of
our lore. Giving installers the ability to remove that Master-Servant
relationship would be nice I think, especially considering pAIs tend to
ignore it anyways.

Also bugs are bad, okay?
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: a pAI's master can now clear the pAI's zeroth law
fix: pAIs are now able to fully utilize installed encryption keys
through their integrated transceiver's menu when they have the
encryption key software upgrade
fix: binary encryption keys work in pAIs that have downloaded the
encryption key software
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants