Players can no longer open additional job slots #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
players can no longer open job slots
|
depending on how much you're willing to add to this, it'd be nice if we could still let players reopen job slots they've previously closed or add job slots if a player is gibbed / DNR, up to the ship's designed maximum. i guess by checking the manifest against the status of those player mobs (alive? doesn't exist? DNR?) |
This is now performed |
|
I trust your code is good honestly typescript is above me, rest looks fine though |
shiptest-server
pushed a commit
that referenced
this pull request
Mar 12, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Mar 23, 2024
## Changelog :cl: balance: Only admins can open job slots fix: Cryoing correctly opens a job slot code: Refactored ShipOwner into tsx /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Constellado
added a commit
to Constellado/PentestOld
that referenced
this pull request
Jun 13, 2024
Reverts shiptest-ss13#2824 from shiptest upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
🆑
balance: Only admins can open job slots
fix: Cryoing correctly opens a job slot
code: Refactored ShipOwner into tsx
/:cl: